From: "Michal Vokáč" <vokac.m@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com,
andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org,
davem@davemloft.net, michal.vokac@ysoft.com
Subject: [PATCH net-next v2 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port
Date: Tue, 22 May 2018 13:16:28 +0200 [thread overview]
Message-ID: <1526987792-56861-4-git-send-email-michal.vokac@ysoft.com> (raw)
In-Reply-To: <1526987792-56861-1-git-send-email-michal.vokac@ysoft.com>
When a port is brought up/down do not enable/disable only the TXMAC
but the RXMAC as well. This is essential for the CPU port to work.
Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:
- Add "Fixes" tag as pointed out by Florian.
- Add "Reviewed-by" tags from Andrew and Florian.
drivers/net/dsa/qca8k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 6a3ffb2..0d224f3 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -516,7 +516,7 @@ qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int mode)
static void
qca8k_port_set_status(struct qca8k_priv *priv, int port, int enable)
{
- u32 mask = QCA8K_PORT_STATUS_TXMAC;
+ u32 mask = QCA8K_PORT_STATUS_TXMAC | QCA8K_PORT_STATUS_RXMAC;
pr_debug("qca: port %i set status %i\n", port, enable);
--
2.1.4
next prev parent reply other threads:[~2018-05-22 11:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 11:16 [PATCH net-next v2 0/7] Add support for QCA8334 switch Michal Vokáč
2018-05-22 11:16 ` [PATCH net-next v2 1/7] net: dsa: qca8k: Add QCA8334 binding documentation Michal Vokáč
2018-05-22 19:40 ` Rob Herring
2018-05-22 20:50 ` Michal
2018-05-22 21:58 ` Andrew Lunn
2018-05-22 11:16 ` [PATCH net-next v2 2/7] net: dsa: qca8k: Add support for QCA8334 switch Michal Vokáč
2018-05-22 21:58 ` [PATCH net-next v2 2/7] net: dsa: qca8k: Add support for QCA8334 switch' Andrew Lunn
2018-05-22 11:16 ` Michal Vokáč [this message]
2018-05-22 11:16 ` [PATCH net-next v2 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth Michal Vokáč
2018-05-22 11:16 ` [PATCH net-next v2 5/7] net: dsa: qca8k: Allow overwriting CPU port setting Michal Vokáč
2018-05-22 11:16 ` [PATCH net-next v2 6/7] net: dsa: qca8k: Replace GPL boilerplate by SPDX Michal Vokáč
2018-05-22 11:16 ` [PATCH net-next v2 7/7] net: dsa: qca8k: Remove redundant parentheses Michal Vokáč
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526987792-56861-4-git-send-email-michal.vokac@ysoft.com \
--to=vokac.m@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.vokac@ysoft.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).