From: Pkshih <pkshih@realtek.com>
To: "joe@perches.com" <joe@perches.com>,
"zhongjiang@huawei.com" <zhongjiang@huawei.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen'
Date: Wed, 24 Oct 2018 00:52:44 +0000 [thread overview]
Message-ID: <1540342331.2495.1.camel@realtek.com> (raw)
In-Reply-To: <19b16ca89b5cde607338513638d4ef8e3a3d2802.camel@perches.com>
On Tue, 2018-10-23 at 12:33 -0700, Joe Perches wrote:
> On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote:
> > radiob_array_table' and 'radiob_arraylen' are not used after setting its
> value.
> > It is safe to remove the unused variable. Meanwhile, radio B radio should be
> > removed as well. because it will no longer be referenced.
>
> The patch subject is a bit off and too generic here.
>
> This is specific to rtl8723ae and not rtlwifi so it is
> probably better for the subject to be something like:
>
> [PATCH] rtl8723ae: Remove set but not used variables and #defines
I'd like 'rtlwifi: rtl8723ae: ' as subject prefix.
>
> > Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> > ---
> > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +----
> > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ----
> > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 --
>
>
> ------Please consider the environment before printing this e-mail.
next prev parent reply other threads:[~2018-10-24 0:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 8:28 [PATCH v2] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen' zhong jiang
2018-10-23 9:35 ` Pkshih
2018-10-23 19:33 ` Joe Perches
2018-10-24 0:52 ` Pkshih [this message]
2018-10-24 2:04 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540342331.2495.1.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).