From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3373AC282C4 for ; Tue, 12 Feb 2019 15:51:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 018D421773 for ; Tue, 12 Feb 2019 15:51:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="XrpAzqFD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730717AbfBLPv4 (ORCPT ); Tue, 12 Feb 2019 10:51:56 -0500 Received: from m12-13.163.com ([220.181.12.13]:50848 "EHLO m12-13.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729355AbfBLPv4 (ORCPT ); Tue, 12 Feb 2019 10:51:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=kA0CKURe/u9l5qpwON TSdOQ20qN4fhdFPCj8bACRK3k=; b=XrpAzqFDXvvIE0YPuC55ml/qB/+M889/u8 mYqKzA9cfYj4LIHm5MK9CzUCNIEdQkEcV1CB5mqRWaOQSqJsQco42y1bsffc2GgK 2avuymKxAG8XG0gL7qQifswu3pZ71S3Ip4JUTsop06wZ/Pp/c1LUpe75JdPXhJ54 R7nykzvpg= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp9 (Coremail) with SMTP id DcCowAB3MIqS62JcPZnCEw--.57859S3; Tue, 12 Feb 2019 23:51:47 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: jcliburn@gmail.com, chris.snook@gmail.com, davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: atheros: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Tue, 12 Feb 2019 23:51:45 +0800 Message-Id: <1549986705-4915-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DcCowAB3MIqS62JcPZnCEw--.57859S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZrWDur1xZFWUtryrJr4kCrg_yoW8GF1Dp3 98CayDCrs7J34UX3WkAa18WFZ3XayqqryUKFZ3G3yrZr9ayr4DXryUKa4jyrWYyrWkKr1a vr4jv34xtF98Jw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UD739UUUUU= X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiwBNZolXli1SIQwAAsM Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 2 +- drivers/net/ethernet/atheros/atlx/atl1.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c index 3164aad..9dfe6a9 100644 --- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c +++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c @@ -1259,7 +1259,7 @@ static bool atl1e_clean_tx_irq(struct atl1e_adapter *adapter) } if (tx_buffer->skb) { - dev_kfree_skb_irq(tx_buffer->skb); + dev_consume_skb_irq(tx_buffer->skb); tx_buffer->skb = NULL; } diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c index 63edc57..9e07b469 100644 --- a/drivers/net/ethernet/atheros/atlx/atl1.c +++ b/drivers/net/ethernet/atheros/atlx/atl1.c @@ -2088,7 +2088,7 @@ static int atl1_intr_tx(struct atl1_adapter *adapter) } if (buffer_info->skb) { - dev_kfree_skb_irq(buffer_info->skb); + dev_consume_skb_irq(buffer_info->skb); buffer_info->skb = NULL; } -- 2.7.4