From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A57C8C43381 for ; Fri, 15 Feb 2019 14:50:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72FE92192D for ; Fri, 15 Feb 2019 14:50:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bH8TzAtw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731925AbfBOOuU (ORCPT ); Fri, 15 Feb 2019 09:50:20 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:40405 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbfBOOuT (ORCPT ); Fri, 15 Feb 2019 09:50:19 -0500 Received: by mail-pl1-f195.google.com with SMTP id bj4so5059511plb.7 for ; Fri, 15 Feb 2019 06:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=a9b2e+K4YCb5BqtjgCbZQhHn574o6+YljzA1/Zvl8ns=; b=bH8TzAtwJpT5h0J1I77iwxOfdkbtVAV0KYb1pzGDtSpJLIcHfOoTSTr235wxQOq+Da FmJ6kuJ3HXpqbVMPYeXpD6pY9C936znjWLUq2q1ki/r7PACn0d0iWljvD56QvCqSdEXV XMDPezMpblYL2b8fTSTylFjYf9tj/27aTY2DUivfjC9JnO4jnEwO7/2qyqYj7BV6vpQn 8cZGs53sVzcEZrjfK3BWXiJA9VUInXYYrHWfkzuwZEzwFLn0exGicSPFtSp6QFZULjTv u7q+yi8zHEDvEFKsGLaCXYkj6D+xGwXpRm4ZiwxAp22gG4gZ4o6tyk6t+LR9RjelQ7kv qNVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=a9b2e+K4YCb5BqtjgCbZQhHn574o6+YljzA1/Zvl8ns=; b=FJRPn7/RQ23VbPF4DzanrkpuUPmqpkASu9YRoepvESEsuPniUCcllV5vKcfGYS0Zi/ IfT/cDktdxrIodje9YApXTguY+na5DQGA8lHBoput/O9dNx6jTEvb9QcIXrDZpEStv8g 2iAnJZO7vsiqZO9uuxpbwZcZ5mu1JXgpH64cCHOyvapxTlwG/yp+sGLvtFzs5Oh6upom gPVVHnNvaEE2dcz0Ku+JPdUTlBJuFyFgOlC8o/+BxRJobDighMnJUY45bXGrn7ZjvXox VN+RvGb6qatwaE03PW/PiXe1x0K5GeyBLxqjOQmg2xgIxGlm1VR1u+YukZz8gdIlH74O kPiw== X-Gm-Message-State: AHQUAuZF1QGtFWxvuw8SLEwLdNjG55CfCtCvhhgtcKwQKXAtuEF0qC1P Cj9q5IJ5LSBCi9zss+IB4sk= X-Google-Smtp-Source: AHgI3IbdCrsujFSJ273i6VZAJfwVhAVWTKDc3ecN/hnJFJJP/EDcaFSU+cRUyzGpSS8Tl3UKPhtmJQ== X-Received: by 2002:a17:902:b701:: with SMTP id d1mr10114052pls.124.1550242219123; Fri, 15 Feb 2019 06:50:19 -0800 (PST) Received: from localhost.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id k65sm1900870pge.74.2019.02.15.06.50.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 06:50:18 -0800 (PST) From: Yafang Shao To: davem@davemloft.net Cc: daniel@iogearbox.net, edumazet@google.com, netdev@vger.kernel.org, shaoyafang@didiglobal.com, Yafang Shao Subject: [net-next 3/5] appletalk: clean up SOCK_DEBUG() Date: Fri, 15 Feb 2019 22:49:45 +0800 Message-Id: <1550242187-29660-4-git-send-email-laoar.shao@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1550242187-29660-1-git-send-email-laoar.shao@gmail.com> References: <1550242187-29660-1-git-send-email-laoar.shao@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Per discussion with Daniel[1] and Eric[2], the SOCK_DEBUG() is a very ancient interface, which is not very useful for debugging. So we'd better clean up it. This patch cleans up it for appletalk. [1] https://patchwork.ozlabs.org/patch/1035573/ [2] https://patchwork.ozlabs.org/patch/1040533/ Signed-off-by: Yafang Shao --- net/appletalk/ddp.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 9b6bc5a..326c4fd 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1608,8 +1608,6 @@ static int atalk_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) } /* Build a packet */ - SOCK_DEBUG(sk, "SK %p: Got address.\n", sk); - /* For headers */ size = sizeof(struct ddpehdr) + len + ddp_dl->header_length; @@ -1628,10 +1626,6 @@ static int atalk_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) goto out; dev = rt->dev; - - SOCK_DEBUG(sk, "SK %p: Size needed %d, device %s\n", - sk, size, dev->name); - size += dev->hard_header_len; release_sock(sk); skb = sock_alloc_send_skb(sk, size, (flags & MSG_DONTWAIT), &err); @@ -1643,8 +1637,6 @@ static int atalk_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) skb_reserve(skb, dev->hard_header_len); skb->dev = dev; - SOCK_DEBUG(sk, "SK %p: Begin build.\n", sk); - ddp = skb_put(skb, sizeof(struct ddpehdr)); ddp->deh_len_hops = htons(len + sizeof(*ddp)); ddp->deh_dnet = usat->sat_addr.s_net; @@ -1654,8 +1646,6 @@ static int atalk_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) ddp->deh_dport = usat->sat_port; ddp->deh_sport = at->src_port; - SOCK_DEBUG(sk, "SK %p: Copy user data (%zd bytes).\n", sk, len); - err = memcpy_from_msg(skb_put(skb, len), msg, len); if (err) { kfree_skb(skb); @@ -1678,7 +1668,6 @@ static int atalk_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) if (skb2) { loopback = 1; - SOCK_DEBUG(sk, "SK %p: send out(copy).\n", sk); /* * If it fails it is queued/sent above in the aarp queue */ @@ -1687,7 +1676,6 @@ static int atalk_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) } if (dev->flags & IFF_LOOPBACK || loopback) { - SOCK_DEBUG(sk, "SK %p: Loop back.\n", sk); /* loop back */ skb_orphan(skb); if (ddp->deh_dnode == ATADDR_BCAST) { @@ -1707,7 +1695,6 @@ static int atalk_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) } ddp_dl->request(ddp_dl, skb, dev->dev_addr); } else { - SOCK_DEBUG(sk, "SK %p: send out.\n", sk); if (rt->flags & RTF_GATEWAY) { gsat.sat_addr = rt->gateway; usat = &gsat; @@ -1718,7 +1705,6 @@ static int atalk_sendmsg(struct socket *sock, struct msghdr *msg, size_t len) */ aarp_send_ddp(dev, skb, &usat->sat_addr, NULL); } - SOCK_DEBUG(sk, "SK %p: Done write (%zd).\n", sk, len); out: release_sock(sk); -- 1.8.3.1