From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D834C43381 for ; Mon, 25 Feb 2019 11:07:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D9BB21734 for ; Mon, 25 Feb 2019 11:07:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sK1nATf7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726818AbfBYLHE (ORCPT ); Mon, 25 Feb 2019 06:07:04 -0500 Received: from mail-it1-f195.google.com ([209.85.166.195]:39501 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbfBYLHC (ORCPT ); Mon, 25 Feb 2019 06:07:02 -0500 Received: by mail-it1-f195.google.com with SMTP id l15so12641399iti.4 for ; Mon, 25 Feb 2019 03:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Yr4MSHIopFCdm/pFaphsfAjIyI8E7658VpQPQW6JN2U=; b=sK1nATf7uBR98ngO3yUO9HbqURhT5dEQfEiqeQQtRq/phe6e0KINbPibTa7lt8/lx3 9fLsHZzV8SL8m8o9Imlcq+dvsJQR3BqjarhLcysBdN80EHkqlEGmzInK5IOECsYCcOuQ o4zL4Gi/BQx/+1LDyVjU7V91TsLqBucdobWYoyJyMbxCaBnKBMjM6fchacJaUyHmE8F4 NK+S+lQaJsioCF/bfPbeAVEWDlEz7S4Nxxija6qV0YPEBJi02z782V/vUVa9IhFP1Dj+ 4nBSOftYF8JpCpEMk13rDzf0RdA5vYRHLG1oDDr/1NFbb3SBmfcOXEkRCak5y7KdLX2/ OIEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Yr4MSHIopFCdm/pFaphsfAjIyI8E7658VpQPQW6JN2U=; b=NaifNcVAg+kfcKJcQNbJ8ILpughYFSC26ATkF/N8GoE/FF4DniOK1lymIT/dger+Aj qThD59PltZYnvh+kqRD8OLTYsdTUtwV3ijyvJSerCQp/56wOXM/EPxbIia4EoegHDitB SqZszOFoj17Mv+NIPHGn8Y7q7Uky1Pzqdf05ccsIE+5wwEQjS/9843WKy3Mr9A0A/K/J 5IEjv7hh4/636P6Khf+DJO8Denq3in3iMNwuvBRaNJG04I4u1xoxp92QcnGfMi7ScBWB +wkDwrMMZK8oXBnwHGBHmJHp9VZFuiNAQASecSn6Iug5gyewqIgI7hdezLMr0XQZiAAr Lc1g== X-Gm-Message-State: AHQUAua1K0TbbJ973P2S37JUMW94zQgyNnfxo+VUqM4Yx2XoTB9zAIi2 4hGI3Z8SgtTcELxEqb4bid0= X-Google-Smtp-Source: AHgI3IYmwkd7yc9o8BWzeXqMQx8OUPakLc2t9zZfac3DUdK9oCf/CtndDe5ZzqWS7mvPuEWpOl6o9w== X-Received: by 2002:a02:308:: with SMTP id y8mr9658647jad.142.1551092821079; Mon, 25 Feb 2019 03:07:01 -0800 (PST) Received: from local.opencloud.tech.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id c1sm4768369itd.23.2019.02.25.03.06.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 03:07:00 -0800 (PST) From: xiangxia.m.yue@gmail.com To: saeedm@mellanox.com, gerlitz.or@gmail.com Cc: netdev@vger.kernel.org, Tonghao Zhang Subject: [PATCH net-next v2 5/5] net/mlx5e: Return -EOPNOTSUPP when attempting to offload an unsupported action Date: Mon, 25 Feb 2019 02:40:07 -0800 Message-Id: <1551091207-10366-6-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1551091207-10366-1-git-send-email-xiangxia.m.yue@gmail.com> References: <1551091207-10366-1-git-send-email-xiangxia.m.yue@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tonghao Zhang The encapsulation is not supported for mlx5 VFs. When we try to offload that action, the -EINVAL is returned, but not -EOPNOTSUPP. This patch changes the returned value and ignore to confuse user. For example: (p2p1_0 is VF net device) tc filter add dev p2p1_0 protocol ip parent ffff: prio 1 flower skip_sw \ src_mac e4:11:22:33:44:01 \ action tunnel_key set \ src_ip 1.1.1.100 \ dst_ip 1.1.1.200 \ dst_port 4789 id 100 \ action mirred egress redirect dev vxlan0 "RTNETLINK answers: Invalid argument" Signed-off-by: Tonghao Zhang --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index d9fcb14..f5029ea 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -2302,7 +2302,8 @@ static int parse_tc_nic_actions(struct mlx5e_priv *priv, } break; default: - return -EINVAL; + NL_SET_ERR_MSG_MOD(extack, "The offload action is not supported"); + return -EOPNOTSUPP; } } @@ -2624,7 +2625,8 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, break; } default: - return -EINVAL; + NL_SET_ERR_MSG_MOD(extack, "The offload action is not supported"); + return -EOPNOTSUPP; } } -- 1.8.3.1