From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E16AC43381 for ; Wed, 13 Mar 2019 12:59:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2076214AE for ; Wed, 13 Mar 2019 12:59:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="MG925rPx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726183AbfCMM7k (ORCPT ); Wed, 13 Mar 2019 08:59:40 -0400 Received: from smtp-fw-2101.amazon.com ([72.21.196.25]:54433 "EHLO smtp-fw-2101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbfCMM7k (ORCPT ); Wed, 13 Mar 2019 08:59:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1552481979; x=1584017979; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2MRVxIBQyGn9Sep/C5Q1RvzEyVNuTyUk5swPXWl23OM=; b=MG925rPxSF895LXn4zisic84C1K2ZhDrfBXKB9mpA9vRTaXN2b+tn15T My554DW72ZxiPqqav4PZMK0GGu163EUCjd8J5excqqMwg0VNhVpNL9jml LOREueB78pAwsHMrBFv5duH6S9D0Gj5Fl+EOi5pttx1GqmaySz7OuZqzs s=; X-IronPort-AV: E=Sophos;i="5.58,474,1544486400"; d="scan'208";a="721869905" Received: from iad6-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-2a-1c1b5cdd.us-west-2.amazon.com) ([10.124.125.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 13 Mar 2019 12:59:37 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2a-1c1b5cdd.us-west-2.amazon.com (8.14.7/8.14.7) with ESMTP id x2DCxaAj105475 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 13 Mar 2019 12:59:36 GMT Received: from EX13D02EUC002.ant.amazon.com (10.43.164.14) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 13 Mar 2019 12:59:35 +0000 Received: from EX13D06EUC004.ant.amazon.com (10.43.164.101) by EX13D02EUC002.ant.amazon.com (10.43.164.14) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 13 Mar 2019 12:59:34 +0000 Received: from EX13D06EUC004.ant.amazon.com ([10.43.164.101]) by EX13D06EUC004.ant.amazon.com ([10.43.164.101]) with mapi id 15.00.1367.000; Wed, 13 Mar 2019 12:59:34 +0000 From: "Bshara, Saeed" To: David Miller CC: "netdev@vger.kernel.org" , "Woodhouse, David" , "Machulsky, Zorik" , "Matushevsky, Alexander" , "Wilson, Matt" , "Liguori, Anthony" , "Bshara, Nafea" , "Tzalik, Guy" , "Belgazal, Netanel" , "Saidi, Ali" , "Kiyanovski, Arthur" Subject: Re: [PATCH V1 net 0/2] net: ena: race condition bug fix and version update Thread-Topic: [PATCH V1 net 0/2] net: ena: race condition bug fix and version update Thread-Index: AQHUwi3+ZCw0pOcKW0O9o6BihVZrqaXch8UAgCzo34g= Date: Wed, 13 Mar 2019 12:59:34 +0000 Message-ID: <1552481974151.81058@amazon.com> References: <1549905464-13758-1-git-send-email-akiyano@amazon.com>,<20190212.110632.499796234007955726.davem@davemloft.net> In-Reply-To: <20190212.110632.499796234007955726.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.162.34] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org =0A= =0A= David, =0A= sorry for the late response. I agree that with stable versions the driver v= ersion is not good indication for which exact code is running.=0A= however, we have many users that port the latest ena driver as-is from kern= el sources into their older kernels, mainly to pull new ENA features (e.g. = low latency queues). for those cases, the driver version helps us to identi= fy the driver's code, so in practice this just works fine.=0A= =0A= saeed=0A= =0A= =0A= From: David Miller =0A= Sent: Tuesday, February 12, 2019 9:06 PM=0A= To: Kiyanovski, Arthur=0A= Cc: netdev@vger.kernel.org; Woodhouse, David; Machulsky, Zorik; Matushevsky= , Alexander; Bshara, Saeed; Wilson, Matt; Liguori, Anthony; Bshara, Nafea; = Tzalik, Guy; Belgazal, Netanel; Saidi, Ali=0A= Subject: Re: [PATCH V1 net 0/2] net: ena: race condition bug fix and versio= n update =0A= =A0 =0A= From: =0A= Date: Mon, 11 Feb 2019 19:17:42 +0200=0A= =0A= > From: Arthur Kiyanovski =0A= > =0A= > This patchset includes a fix to a race condition that can cause=0A= > kernel panic, as well as a driver version update because of this=0A= > fix.=0A= =0A= Series applied and patch #1 queued up for -stable.=0A= =0A= But I want to reiterate what Andrew said, the version is so increibly=0A= useless and stupid.=0A= =0A= I'm going to submit the fix to -stable, and then people will then=0A= doubly and triply have no relationship between driver version number=0A= and what fixes exist.=0A= =