From: Oliver Neukum <oliver@neukum.org>
To: Dan Williams <dcbw@redhat.com>
Cc: Ming Lei <tom.leiming@gmail.com>,
Elina Pasheva <epasheva@sierrawireless.com>,
Network Development <netdev@vger.kernel.org>,
linux-usb <linux-usb@vger.kernel.org>,
Rory Filer <rfiler@sierrawireless.com>, Phil Sutter <phil@nwl.cc>
Subject: Re: [PATCH 1/2 v5 RESEND] usbnet: allow status interrupt URB to always be active
Date: Wed, 01 May 2013 09:23:42 +0200 [thread overview]
Message-ID: <15542804.UEZW9B2gES@linux-5eaq.site> (raw)
In-Reply-To: <1367260435.20151.28.camel@dcbw.foobar.com>
On Monday 29 April 2013 13:33:55 Dan Williams wrote:
> Some drivers (sierra_net) need the status interrupt URB
> active even when the device is closed, because they receive
> custom indications from firmware. Add functions to refcount
> the status interrupt URB submit/kill operation so that
> sub-drivers and the generic driver don't fight over whether
> the status interrupt URB is active or not.
>
> A sub-driver can call usbnet_status_start() at any time, but
> the URB is only submitted the first time the function is
> called. Likewise, when the sub-driver is done with the URB,
> it calls usbnet_status_stop() but the URB is only killed when
> all users have stopped it. The URB is still killed and
> re-submitted for suspend/resume, as before, with the same
> refcount it had at suspend.
>
> Signed-off-by: Dan Williams <dcbw@redhat.com>
Acked-by: Oliver Neukum <oliver@neukum.org>
next prev parent reply other threads:[~2013-05-01 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 18:33 [PATCH 1/2 v5 RESEND] usbnet: allow status interrupt URB to always be active Dan Williams
2013-04-29 18:36 ` [PATCH 2/2 v5 RESEND] sierra_net: keep status interrupt URB active Dan Williams
2013-05-01 7:23 ` Oliver Neukum [this message]
[not found] ` <1367260435.20151.28.camel-wKZy7rqYPVb5EHUCmHmTqw@public.gmane.org>
2013-05-01 18:54 ` [PATCH 1/2 v5 RESEND] usbnet: allow status interrupt URB to always be active David Miller
2013-05-01 20:07 ` Dan Williams
[not found] ` <1367438826.12353.13.camel-wKZy7rqYPVb5EHUCmHmTqw@public.gmane.org>
2013-05-01 20:19 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15542804.UEZW9B2gES@linux-5eaq.site \
--to=oliver@neukum.org \
--cc=dcbw@redhat.com \
--cc=epasheva@sierrawireless.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=rfiler@sierrawireless.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).