From: Oliver Neukum <oneukum@suse.com>
To: David Miller <davem@davemloft.net>, Jan.Kloetzke@preh.de
Cc: jan@kloetzke.net, linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] usbnet: fix kernel crash after disconnect
Date: Mon, 06 May 2019 10:17:46 +0200 [thread overview]
Message-ID: <1557130666.12778.3.camel@suse.com> (raw)
In-Reply-To: <20190505.004556.492323065607253635.davem@davemloft.net>
On So, 2019-05-05 at 00:45 -0700, David Miller wrote:
> From: Kloetzke Jan <Jan.Kloetzke@preh.de>
> Date: Tue, 30 Apr 2019 14:15:07 +0000
>
> > @@ -1431,6 +1432,11 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb,
> > spin_unlock_irqrestore(&dev->txq.lock, flags);
> > goto drop;
> > }
> > + if (WARN_ON(netif_queue_stopped(net))) {
> > + usb_autopm_put_interface_async(dev->intf);
> > + spin_unlock_irqrestore(&dev->txq.lock, flags);
> > + goto drop;
> > + }
>
> If this is known to happen and is expected, then we should not warn.
>
Hi,
yes this is the point. Can ndo_start_xmit() and ndo_stop() race?
If not, why does the patch fix the observed issue and what
prevents the race? Something is not clear here.
Regards
Oliver
next prev parent reply other threads:[~2019-05-06 8:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 9:19 [PATCH] usbnet: fix kernel crash after disconnect Kloetzke Jan
2019-04-18 6:37 ` Oliver Neukum
2019-04-18 8:02 ` Kloetzke Jan
2019-04-18 23:35 ` David Miller
2019-04-19 7:17 ` Jan Klötzke
2019-04-29 18:48 ` Oliver Neukum
2019-04-30 14:08 ` Kloetzke Jan
2019-04-30 14:15 ` [PATCH v2] " Kloetzke Jan
2019-05-05 7:45 ` David Miller
2019-05-06 8:17 ` Oliver Neukum [this message]
2019-05-16 7:10 ` Kloetzke Jan
2019-05-21 0:09 ` David Miller
2019-05-21 9:48 ` Oliver Neukum
2019-05-21 10:12 ` Kloetzke Jan
2019-05-21 11:42 ` Oliver Neukum
2019-05-21 13:18 ` [PATCH v3] " Kloetzke Jan
2019-05-21 20:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557130666.12778.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=Jan.Kloetzke@preh.de \
--cc=davem@davemloft.net \
--cc=jan@kloetzke.net \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).