From: Jesper Dangaard Brouer <brouer@redhat.com>
To: netdev@vger.kernel.org,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Tariq Toukan" <tariqt@mellanox.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>
Cc: toshiaki.makita1@gmail.com, grygorii.strashko@ti.com,
ivan.khoronzhuk@linaro.org, mcroce@redhat.com
Subject: [PATCH net-next v2 00/12] xdp: page_pool fixes and in-flight accounting
Date: Tue, 18 Jun 2019 15:05:07 +0200 [thread overview]
Message-ID: <156086304827.27760.11339786046465638081.stgit@firesoul> (raw)
This patchset fix page_pool API and users, such that drivers can use it for
DMA-mapping. A number of places exist, where the DMA-mapping would not get
released/unmapped, all these are fixed. This occurs e.g. when an xdp_frame
gets converted to an SKB. As network stack doesn't have any callback for XDP
memory models.
The patchset also address a shutdown race-condition. Today removing a XDP
memory model, based on page_pool, is only delayed one RCU grace period. This
isn't enough as redirected xdp_frames can still be in-flight on different
queues (remote driver TX, cpumap or veth).
We stress that when drivers use page_pool for DMA-mapping, then they MUST
use one packet per page. This might change in the future, but more work lies
ahead, before we can lift this restriction.
This patchset change the page_pool API to be more strict, as in-flight page
accounting is added.
---
Ilias Apalodimas (2):
net: page_pool: add helper function to retrieve dma addresses
net: page_pool: add helper function to unmap dma addresses
Jesper Dangaard Brouer (10):
xdp: fix leak of IDA cyclic id if rhashtable_insert_slow fails
xdp: page_pool related fix to cpumap
veth: use xdp_release_frame for XDP_PASS
page_pool: introduce page_pool_free and use in mlx5
mlx5: more strict use of page_pool API
xdp: tracking page_pool resources and safe removal
xdp: force mem allocator removal and periodic warning
xdp: add tracepoints for XDP mem
page_pool: add tracepoints for page_pool with details need by XDP
page_pool: make sure struct device is stable
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 12 +-
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 3 -
drivers/net/veth.c | 1
include/net/page_pool.h | 69 +++++++++++-
include/net/xdp.h | 15 +++
include/net/xdp_priv.h | 23 ++++
include/trace/events/page_pool.h | 87 +++++++++++++++
include/trace/events/xdp.h | 115 ++++++++++++++++++++
kernel/bpf/cpumap.c | 3 +
net/core/net-traces.c | 4 +
net/core/page_pool.c | 95 +++++++++++++++--
net/core/xdp.c | 120 ++++++++++++++++++---
12 files changed, 502 insertions(+), 45 deletions(-)
create mode 100644 include/net/xdp_priv.h
create mode 100644 include/trace/events/page_pool.h
--
next reply other threads:[~2019-06-18 13:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 13:05 Jesper Dangaard Brouer [this message]
2019-06-18 13:05 ` [PATCH net-next v2 01/12] net: page_pool: add helper function to retrieve dma addresses Jesper Dangaard Brouer
2019-06-18 13:05 ` [PATCH net-next v2 02/12] net: page_pool: add helper function to unmap " Jesper Dangaard Brouer
2019-06-18 13:05 ` [PATCH net-next v2 03/12] xdp: fix leak of IDA cyclic id if rhashtable_insert_slow fails Jesper Dangaard Brouer
2019-06-18 13:05 ` [PATCH net-next v2 04/12] xdp: page_pool related fix to cpumap Jesper Dangaard Brouer
2019-06-18 13:05 ` [PATCH net-next v2 05/12] veth: use xdp_release_frame for XDP_PASS Jesper Dangaard Brouer
2019-06-18 13:05 ` [PATCH net-next v2 06/12] page_pool: introduce page_pool_free and use in mlx5 Jesper Dangaard Brouer
2019-06-18 13:05 ` [PATCH net-next v2 07/12] mlx5: more strict use of page_pool API Jesper Dangaard Brouer
2019-06-18 13:05 ` [PATCH net-next v2 08/12] xdp: tracking page_pool resources and safe removal Jesper Dangaard Brouer
2019-06-25 10:50 ` Ivan Khoronzhuk
2019-06-25 11:27 ` Jesper Dangaard Brouer
2019-06-25 11:51 ` Ivan Khoronzhuk
2019-06-25 12:28 ` Ivan Khoronzhuk
2019-06-18 13:05 ` [PATCH net-next v2 09/12] xdp: force mem allocator removal and periodic warning Jesper Dangaard Brouer
2019-06-18 13:05 ` [PATCH net-next v2 10/12] xdp: add tracepoints for XDP mem Jesper Dangaard Brouer
2019-06-18 13:06 ` [PATCH net-next v2 11/12] page_pool: add tracepoints for page_pool with details need by XDP Jesper Dangaard Brouer
2019-06-18 13:06 ` [PATCH net-next v2 12/12] page_pool: make sure struct device is stable Jesper Dangaard Brouer
2019-06-19 15:24 ` [PATCH net-next v2 00/12] xdp: page_pool fixes and in-flight accounting David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156086304827.27760.11339786046465638081.stgit@firesoul \
--to=brouer@redhat.com \
--cc=grygorii.strashko@ti.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ivan.khoronzhuk@linaro.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
--cc=toke@toke.dk \
--cc=toshiaki.makita1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).