From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6AF1C3A5AA for ; Thu, 5 Sep 2019 12:43:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FCF520DD4 for ; Thu, 5 Sep 2019 12:43:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389475AbfIEMnb (ORCPT ); Thu, 5 Sep 2019 08:43:31 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:58417 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389445AbfIEMn3 (ORCPT ); Thu, 5 Sep 2019 08:43:29 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from tariqt@mellanox.com) with ESMTPS (AES256-SHA encrypted); 5 Sep 2019 15:43:23 +0300 Received: from dev-l-vrt-207-011.mtl.labs.mlnx. (dev-l-vrt-207-011.mtl.labs.mlnx [10.134.207.11]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x85ChNGa021437; Thu, 5 Sep 2019 15:43:23 +0300 From: Tariq Toukan To: Stephen Hemminger , David Ahern Cc: netdev@vger.kernel.org, Moshe Shemesh , Aya Levin , Jiri Pirko , Tariq Toukan Subject: [PATCH iproute2 3/4] devlink: Fix inconsistency between command input and output Date: Thu, 5 Sep 2019 15:43:06 +0300 Message-Id: <1567687387-12993-4-git-send-email-tariqt@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1567687387-12993-1-git-send-email-tariqt@mellanox.com> References: <1567687387-12993-1-git-send-email-tariqt@mellanox.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Aya Levin In devlink health show command the reporter's name parameter is called reporter, but in the output the reporter's name is referred to as name Before this patch: $ devlink health show pci/0000:04:00.0 reporter tx pci/0000:04:00.0: name tx state healthy error 0 recover 0 grace_period 500 auto_recover true After this patch: $ devlink health show pci/0000:04:00.0 reporter tx pci/0000:04:00.0: reporter tx state healthy error 0 recover 0 grace_period 500 auto_recover true Fixes: 2f1242efe9d0 ("devlink: Add devlink health show command") Signed-off-by: Aya Levin Reported-by: Jiri Pirko Acked-by: Jiri Pirko Signed-off-by: Tariq Toukan --- devlink/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index 1bfc3283a832..722b6a101673 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -6377,7 +6377,7 @@ static void pr_out_health(struct dl *dl, struct nlattr **tb_health) pr_out_handle_start_arr(dl, tb_health); - pr_out_str(dl, "name", + pr_out_str(dl, "reporter", mnl_attr_get_str(tb[DEVLINK_ATTR_HEALTH_REPORTER_NAME])); if (!dl->json_output) { __pr_out_newline(); -- 1.8.3.1