From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D513C49ED7 for ; Fri, 20 Sep 2019 12:50:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E71952073F for ; Fri, 20 Sep 2019 12:50:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="ijzzmZ3n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726556AbfITMun (ORCPT ); Fri, 20 Sep 2019 08:50:43 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:38552 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726500AbfITMum (ORCPT ); Fri, 20 Sep 2019 08:50:42 -0400 Received: by mail-qk1-f193.google.com with SMTP id u186so7162676qkc.5 for ; Fri, 20 Sep 2019 05:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=2hQDTQjnSsW1VsG1oz7/x04n4JF0426dRW41K9FNadk=; b=ijzzmZ3nvF7W4G6FRYIveg83+VVXhZ1mbySwLz7P7vjbMH20YscYZLMa6yQ1Ei211J rauPw9Bs3NzG3FilFYH4usejb8l+vmPvaElVOhJAnFRWMrLoV0Awdey55Jm0QEJdgN+7 4Pf3qhjAAVCv5g9GQovJ3UeJ3u7wLUaKGFQ85WtB8st4NoUKy9RWRdsaBTxMNzD1c01P e4c3briubZW7NQ8e9ltVbNKymhKjonZIDtBC5u4xkTxnNeKdY07M9/jPQTmjSzBGSunV OQaVqjiO1QXuxaypDk1MoJvp1JEAkFkjdTdHEAIWj720NGgurgqKPGGQsEa8yt+JrfkU IJhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=2hQDTQjnSsW1VsG1oz7/x04n4JF0426dRW41K9FNadk=; b=m1B8usFFOZroB5BtjlDYJ9CkAF+z1Wv+7RhMcyUeoR8Cp/T/8Qvzi7HX3QM/mNKqpI W9wxmfjfoA22CvI3h4L31cVjEgyU2y0ascOihoFFFk/lzGH147QZ3WmhueHUjVBcONB+ 2KCU5uwIqihh6VL617XkoC9XAaC9ESzTzcFjIi/G4lq3QUpcjYKwzRrFmhijDUSLjN8Y z8+lkClF5ic4UeCQyX1T2CuLyBQy9WlBpL7dzdV+AQFcHPmBTmGDbIcwmZpZ+BOW5ZA6 UJ8IeJwiYkt4VJS0dwv189I9FlEkYV0N6nh0gOoVDCObARGsfeUCMpF4PcvMIiT4Z0n3 yeGQ== X-Gm-Message-State: APjAAAXCEcwfa9y1ATzAkOaMSOkVEO9JEz7iST3F8aIOd5VUyg7wGcus kgCu4CXTSNnCKl7t+hvtjYnVBA== X-Google-Smtp-Source: APXvYqznecK3jhF+TBvYQOTZsoN72Wk/TTjLaioqEkVwBlAC/rb6eqpqbrFQUgdUDhneH2y8w9Ptrg== X-Received: by 2002:a37:a9c1:: with SMTP id s184mr3481758qke.360.1568983840132; Fri, 20 Sep 2019 05:50:40 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id a11sm931585qkc.123.2019.09.20.05.50.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Sep 2019 05:50:38 -0700 (PDT) Message-ID: <1568983836.5576.194.camel@lca.pw> Subject: Re: [PATCH -next] treewide: remove unused argument in lock_release() From: Qian Cai To: Will Deacon , torvalds@linux-foundation.org Cc: ast@kernel.org, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, gregkh@linuxfoundation.org, jslaby@suse.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org, tytso@mit.edu, jack@suse.com, linux-ext4@vger.kernel.org, tj@kernel.org, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, ocfs2-devel@oss.oracle.com, davem@davemloft.net, daniel@iogearbox.net, netdev@vger.kernel.org, bpf@vger.kernel.org, duyuyang@gmail.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, alexander.levin@microsoft.com Date: Fri, 20 Sep 2019 08:50:36 -0400 In-Reply-To: <20190920093700.7nfaghxdrmubp2do@willie-the-truck> References: <1568909380-32199-1-git-send-email-cai@lca.pw> <20190920093700.7nfaghxdrmubp2do@willie-the-truck> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 2019-09-20 at 10:38 +0100, Will Deacon wrote: > On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote: > > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > > in __lock_release"), @nested is no longer used in lock_release(), so > > remove it from all lock_release() calls and friends. > > > > Signed-off-by: Qian Cai > > --- > > Although this looks fine to me at a first glance, it might be slightly > easier to manage if you hit {spin,rwlock,seqcount,mutex,rwsem}_release() > first with coccinelle scripts, and then hack lock_release() as a final > patch. That way it's easy to regenerate things if needed. I am not sure if it worth the extra efforts where I have to retest it on all architectures, and the patch is really simple, but I can certainly do that if you insist. I have just confirmed the patch [1] also applied correctly to the latest mainline, so it might be the best time just for Linus to merge it directly so it does not introduce build errors later on? [1] https://lore.kernel.org/lkml/1568909380-32199-1-git-send-email-cai@lca.pw/