From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46F4ECE58D for ; Thu, 17 Oct 2019 20:35:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC0E921835 for ; Thu, 17 Oct 2019 20:35:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437216AbfJQUfP (ORCPT ); Thu, 17 Oct 2019 16:35:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:33790 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2391182AbfJQUfP (ORCPT ); Thu, 17 Oct 2019 16:35:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F12B3AE4D; Thu, 17 Oct 2019 20:35:13 +0000 (UTC) Message-ID: <1571344510.5264.18.camel@suse.com> Subject: Re: [PATCH] usb: hso: obey DMA rules in tiocmget From: Oliver Neukum To: David Miller Cc: johan@kernel.org, netdev@vger.kernel.org Date: Thu, 17 Oct 2019 22:35:10 +0200 In-Reply-To: <20191017.142055.130965767343659716.davem@davemloft.net> References: <20191017095339.25034-1-oneukum@suse.com> <20191017.141955.1615614075310331285.davem@davemloft.net> <20191017.142055.130965767343659716.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am Donnerstag, den 17.10.2019, 14:20 -0400 schrieb David Miller: > From: David Miller > Date: Thu, 17 Oct 2019 14:19:55 -0400 (EDT) > > > From: Oliver Neukum > > Date: Thu, 17 Oct 2019 11:53:38 +0200 > > > > > The serial state information must not be embedded into another > > > data structure, as this interferes with cache handling for DMA > > > on architectures without cache coherence.. > > > That would result in data corruption on some architectures > > > Allocating it separately. > > > > > > Signed-off-by: Oliver Neukum > > > > Applied, thanks Oliver. > > Ugh, Oliver did you even build test this? > > drivers/net/usb/hso.c:189:9: error: expected ‘{’ before ‘*’ token > 189 | struct *hso_serial_state_notification serial_state_notification; > > Seriously, I expect better from an experienced developer such as > yourself. Sorry, that is why I sent a v2. I built it, but not alone. I have a cleanup series for that driver in the works. Sorry Oliver