From: zhong jiang <zhongjiang@huawei.com>
To: <kvalo@codeaurora.org>, <stas.yakovlev@gmail.com>,
<simon.horman@netronome.com>
Cc: <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<zhongjiang@huawei.com>
Subject: [PATCH v2 1/3] ipw2x00: Remove redundant variable "rc"
Date: Fri, 1 Nov 2019 20:33:39 +0800 [thread overview]
Message-ID: <1572611621-13280-2-git-send-email-zhongjiang@huawei.com> (raw)
In-Reply-To: <1572611621-13280-1-git-send-email-zhongjiang@huawei.com>
local variable "rc" is not used. It is safe to remove and
There is only one caller of libipw_qos_convert_ac_to_parameters().
hence make it void
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/net/wireless/intel/ipw2x00/libipw_rx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/libipw_rx.c b/drivers/net/wireless/intel/ipw2x00/libipw_rx.c
index 34cfd81..0cb36d1 100644
--- a/drivers/net/wireless/intel/ipw2x00/libipw_rx.c
+++ b/drivers/net/wireless/intel/ipw2x00/libipw_rx.c
@@ -999,13 +999,12 @@ static int libipw_read_qos_info_element(struct
/*
* Write QoS parameters from the ac parameters.
*/
-static int libipw_qos_convert_ac_to_parameters(struct
+static void libipw_qos_convert_ac_to_parameters(struct
libipw_qos_parameter_info
*param_elm, struct
libipw_qos_parameters
*qos_param)
{
- int rc = 0;
int i;
struct libipw_qos_ac_parameter *ac_params;
u32 txop;
@@ -1030,7 +1029,6 @@ static int libipw_qos_convert_ac_to_parameters(struct
txop = le16_to_cpu(ac_params->tx_op_limit) * 32;
qos_param->tx_op_limit[i] = cpu_to_le16(txop);
}
- return rc;
}
/*
--
1.7.12.4
next prev parent reply other threads:[~2019-11-01 12:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 12:33 [PATCH v2 0/3] wireless: remove unneeded variable and return 0 zhong jiang
2019-11-01 12:33 ` zhong jiang [this message]
2019-11-01 12:33 ` [PATCH v2 2/3] iwlegacy: Remove redundant variable "ret" zhong jiang
2019-11-01 12:33 ` [PATCH v2 3/3] b43legacy: ASoC: ux500: Remove redundant variable "count" zhong jiang
2019-11-01 13:44 ` [PATCH v2 0/3] wireless: remove unneeded variable and return 0 Simon Horman
2019-11-02 9:00 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572611621-13280-2-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).