From: zhong jiang <zhongjiang@huawei.com>
To: <kvalo@codeaurora.org>, <stas.yakovlev@gmail.com>,
<simon.horman@netronome.com>
Cc: <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<zhongjiang@huawei.com>
Subject: [PATCH v3 2/2] iwlegacy: Remove redundant variable "ret"
Date: Sat, 2 Nov 2019 16:55:22 +0800 [thread overview]
Message-ID: <1572684922-61805-3-git-send-email-zhongjiang@huawei.com> (raw)
In-Reply-To: <1572684922-61805-1-git-send-email-zhongjiang@huawei.com>
local variable "ret" is not used. hence it is safe to remove and
just return 0.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
index 51fdd7c..3664f56 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
@@ -3331,7 +3331,6 @@ struct il_mod_params il4965_mod_params = {
struct ieee80211_key_conf *keyconf, u8 sta_id)
{
unsigned long flags;
- int ret = 0;
__le16 key_flags = 0;
key_flags |= (STA_KEY_FLG_TKIP | STA_KEY_FLG_MAP_KEY_MSK);
@@ -3368,7 +3367,7 @@ struct il_mod_params il4965_mod_params = {
spin_unlock_irqrestore(&il->sta_lock, flags);
- return ret;
+ return 0;
}
void
--
1.7.12.4
next prev parent reply other threads:[~2019-11-02 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-02 8:55 [PATCH v3 0/2] wireless: remove unneeded variable and return 0 zhong jiang
2019-11-02 8:55 ` [PATCH v3 1/2] ipw2x00: Remove redundant variable "rc" zhong jiang
2019-11-06 17:53 ` Kalle Valo
2019-11-02 8:55 ` zhong jiang [this message]
2019-11-04 16:20 ` [PATCH v3 0/2] wireless: remove unneeded variable and return 0 Kalle Valo
2019-11-05 12:32 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572684922-61805-3-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).