From: Jesper Dangaard Brouer <brouer@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
netdev@vger.kernel.org,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Saeed Mahameed" <saeedm@mellanox.com>,
"Matteo Croce" <mcroce@redhat.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Tariq Toukan" <tariqt@mellanox.com>
Subject: [net-next v1 PATCH 0/2] Change XDP lifetime guarantees for page_pool objects
Date: Fri, 08 Nov 2019 19:20:17 +0100 [thread overview]
Message-ID: <157323719180.10408.3472322881536070517.stgit@firesoul> (raw)
This patchset change XDP lifetime guarantees for page_pool objects
(registered via the xdp_rxq_info_reg_mem_model API). The new guarantee
is that page_pool objects stay valid (are not free'ed) until all
inflight pages are returned.
It was commit d956a048cd3f (“xdp: force mem allocator removal and
periodic warning”) that introduce the force removal of page_pool
objects (after 120 second). While working on extending page_pool
recycling to cover SKBs[1], we[2] realised that this force removal
approach was a mistake.
Tested and monitored via bpftrace scripts provide here[3].
[1] https://github.com/xdp-project/xdp-project/tree/master/areas/mem
[2] we == Ilias, Jonathan, Tariq, Saeed and me
[3] https://github.com/xdp-project/xdp-project/tree/master/areas/mem/bpftrace
---
Jesper Dangaard Brouer (2):
xdp: revert forced mem allocator removal for page_pool
page_pool: make inflight returns more robust via blocking alloc cache
include/net/page_pool.h | 2 ++
include/trace/events/xdp.h | 35 +++--------------------------------
net/core/page_pool.c | 32 +++++++++++++++++++++++++-------
net/core/xdp.c | 36 +++++++++++++-----------------------
4 files changed, 43 insertions(+), 62 deletions(-)
--
next reply other threads:[~2019-11-08 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 18:20 Jesper Dangaard Brouer [this message]
2019-11-08 18:20 ` [net-next v1 PATCH 1/2] xdp: revert forced mem allocator removal for page_pool Jesper Dangaard Brouer
2019-11-08 19:16 ` Jonathan Lemon
2019-11-09 16:11 ` Jesper Dangaard Brouer
2019-11-09 17:34 ` Jonathan Lemon
2019-11-10 7:59 ` Jesper Dangaard Brouer
2019-11-10 19:56 ` Jonathan Lemon
2019-11-08 18:20 ` [net-next v1 PATCH 2/2] page_pool: make inflight returns more robust via blocking alloc cache Jesper Dangaard Brouer
2019-11-11 0:13 ` kbuild test robot
2019-11-11 0:13 ` [RFC PATCH] page_pool: page_pool_empty_alloc_cache_once() can be static kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157323719180.10408.3472322881536070517.stgit@firesoul \
--to=brouer@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jonathan.lemon@gmail.com \
--cc=lorenzo@kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).