From: David Ahern <dahern@digitalocean.com>
To: Edward Cree <ecree@solarflare.com>,
linux-net-drivers@solarflare.com, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] sfc: change ARFS expiry mechanism
Date: Fri, 22 Nov 2019 14:44:05 -0700 [thread overview]
Message-ID: <1574556c-a4c6-2316-fd0e-41d5e6b40f29@digitalocean.com> (raw)
In-Reply-To: <921437ed-3799-acb5-c451-9cdd5385c219@solarflare.com>
On 11/22/19 10:57 AM, Edward Cree wrote:
> The old rfs_filters_added method for determining the quota could potentially
> allow the NIC to become filled with old filters, which never get tested for
> expiry. Instead, explicitly make expiry check work depend on the number of
> filters installed, and don't count checking slots without filters in as
> doing work. This guarantees that each filter will be checked for expiry at
> least once every thirty seconds (assuming the channel to which it belongs is
> NAPI polling actively) regardless of fill level.
>
> Signed-off-by: Edward Cree <ecree@solarflare.com>
> ---
> drivers/net/ethernet/sfc/efx.c | 8 +++--
> drivers/net/ethernet/sfc/efx.h | 9 +++---
> drivers/net/ethernet/sfc/net_driver.h | 14 ++++----
> drivers/net/ethernet/sfc/rx.c | 46 ++++++++++++++++-----------
> 4 files changed, 45 insertions(+), 32 deletions(-)
>
Tested-By: David Ahern <dahern@digitalocean.com>
next prev parent reply other threads:[~2019-11-22 21:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 17:54 [PATCH net-next 0/4] sfc: ARFS expiry improvements Edward Cree
2019-11-22 17:57 ` [PATCH net-next 1/4] sfc: change ARFS expiry mechanism Edward Cree
2019-11-22 21:44 ` David Ahern [this message]
2019-11-22 17:57 ` [PATCH net-next 2/4] sfc: suppress MCDI errors from ARFS Edward Cree
2019-11-22 21:44 ` David Ahern
2019-11-22 17:57 ` [PATCH net-next 3/4] sfc: add statistics for ARFS Edward Cree
2019-11-23 17:45 ` [PATCH net-next] sfc: fix build without CONFIG_RFS_ACCEL Jakub Kicinski
2019-11-24 22:45 ` Jakub Kicinski
2019-11-25 9:59 ` Edward Cree
2019-11-22 17:57 ` [PATCH net-next 4/4] sfc: do ARFS expiry work occasionally even without NAPI poll Edward Cree
2019-11-23 1:56 ` [PATCH net-next 0/4] sfc: ARFS expiry improvements Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574556c-a4c6-2316-fd0e-41d5e6b40f29@digitalocean.com \
--to=dahern@digitalocean.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).