From: Andre Guedes <andre.guedes@linux.intel.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Murali Karicheri <m-karicheri2@ti.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Po Liu <po.liu@nxp.com>,
"alexandru.ardelean@analog.com" <alexandru.ardelean@analog.com>,
"allison@lohutok.net" <allison@lohutok.net>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"ayal@mellanox.com" <ayal@mellanox.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"hauke.mehrtens@intel.com" <hauke.mehrtens@intel.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"jiri@mellanox.com" <jiri@mellanox.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"saeedm@mellanox.com" <saeedm@mellanox.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
"simon.horman@netronome.com" <simon.horman@netronome.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandru Marginean <alexandru.marginean@nxp.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Roy Zang <roy.zang@nxp.com>, Mingkai Hu <mingkai.hu@nxp.com>,
Jerry Huang <jerry.huang@nxp.com>, Leo Li <leoyang.li@nxp.com>
Subject: Re: [EXT] Re: [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes
Date: Fri, 10 Jan 2020 12:59:26 -0800 [thread overview]
Message-ID: <157868996635.61655.11306531040262384025@aguedesl-mac01.jf.intel.com> (raw)
In-Reply-To: <CA+h21hr9ApvPSYigcS0WkFVg0+Od=G+ZVxkV7GvdaNbDmCmiCA@mail.gmail.com>
Hi Vladimir,
Quoting Vladimir Oltean (2020-01-10 08:02:45)
> > I'm not sure about the knob 'timers (hold/release)' described in the quotes
> > above. I couldn't find a match in the specs. If it refers to 'holdAdvance' and
> > 'releaseAdvance' parameters described in 802.1Q-2018, I believe they are not
> > configurable. Do we know any hardware where they are configurable?
> >
>
> On NXP LS1028A, HOLD_ADVANCE is configurable on both ENETC and the
> Felix switch (its default value is 127 bytes). Same as Synopsys, it is
> a global setting and not per queue or per GCL entry.
> RELEASE_ADVANCE is not configurable.
> Regardless, I am not sure if there is any value in configuring this
> knob. Remember that the minimum guard band size still needs to be
> twice as large as the minimum Ethernet frame size.
Not adding this knob now sounds reasonable to me too, but let's consider it in
the design so we can easily add it later, in case we need it.
Regards,
Andre
next prev parent reply other threads:[~2020-01-10 20:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 9:59 [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes Po Liu
2019-11-27 9:59 ` [v1,net-next, 2/2] enetc: implement the enetc 802.1Qbu hardware function Po Liu
2019-11-27 11:00 ` Vladimir Oltean
2019-12-04 1:35 ` Ivan Khoronzhuk
2019-11-27 18:57 ` [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes David Miller
2019-12-03 15:11 ` Ivan Khoronzhuk
2019-12-11 2:52 ` Andre Guedes
2019-12-16 7:43 ` [EXT] " Po Liu
2019-12-16 21:44 ` Vinicius Costa Gomes
2019-12-19 0:43 ` Ivan Khoronzhuk
2019-12-19 1:54 ` Vinicius Costa Gomes
2019-12-30 16:56 ` Murali Karicheri
2020-01-17 23:47 ` Vinicius Costa Gomes
2019-12-30 17:03 ` Murali Karicheri
2020-01-09 1:07 ` Andre Guedes
2020-01-09 8:59 ` Jose Abreu
2020-01-09 18:04 ` Andre Guedes
2020-01-10 14:35 ` Jose Abreu
2020-01-10 16:02 ` Vladimir Oltean
2020-01-10 20:59 ` Andre Guedes [this message]
2020-01-09 0:56 ` Andre Guedes
2020-01-18 0:03 ` Vinicius Costa Gomes
2020-01-22 18:10 ` Murali Karicheri
2020-01-23 13:30 ` Vladimir Oltean
2020-01-23 17:50 ` Vinicius Costa Gomes
2020-02-10 20:30 ` Murali Karicheri
2020-02-11 19:22 ` Vinicius Costa Gomes
2020-02-25 17:55 ` Murali Karicheri
2020-02-10 20:17 ` Murali Karicheri
2020-02-21 21:43 ` Vinicius Costa Gomes
2020-02-22 3:26 ` [EXT] " Po Liu
2020-02-25 17:59 ` Murali Karicheri
2020-02-25 17:59 ` Murali Karicheri
2020-02-26 2:01 ` Po Liu
2020-03-12 23:34 ` Vinicius Costa Gomes
2020-03-13 6:00 ` Po Liu
2020-03-18 14:07 ` Murali Karicheri
2020-05-13 14:55 ` Murali Karicheri
2020-05-13 17:21 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157868996635.61655.11306531040262384025@aguedesl-mac01.jf.intel.com \
--to=andre.guedes@linux.intel.com \
--cc=alexandru.ardelean@analog.com \
--cc=alexandru.marginean@nxp.com \
--cc=allison@lohutok.net \
--cc=andrew@lunn.ch \
--cc=ayal@mellanox.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hauke.mehrtens@intel.com \
--cc=hkallweit1@gmail.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jerry.huang@nxp.com \
--cc=jiri@mellanox.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mingkai.hu@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pablo@netfilter.org \
--cc=po.liu@nxp.com \
--cc=roy.zang@nxp.com \
--cc=saeedm@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=tglx@linutronix.de \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).