From: "huangguangbin (A)" <huangguangbin2@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lipeng321@huawei.com>
Subject: Re: [PATCH net-next 4/4] net: hns3: add support ethtool extended link state
Date: Tue, 10 Aug 2021 09:08:56 +0800 [thread overview]
Message-ID: <15810974-d1da-2a43-7a69-45dffff653a2@huawei.com> (raw)
In-Reply-To: <20210809135456.397129f5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2021/8/10 4:54, Jakub Kicinski wrote:
> On Mon, 9 Aug 2021 22:50:42 +0800 Guangbin Huang wrote:
>> + if (!h->ae_algo->ops->get_link_diagnosis_info)
>> + return -EOPNOTSUP;
>
> Missing a P at the end here, this patch does not build.
> .
>
I am very sorry, I will modify this fault and pay attentiaon to it later.
prev parent reply other threads:[~2021-08-10 1:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 14:50 [PATCH net-next 0/4] net: hns3: add support ethtool extended link state Guangbin Huang
2021-08-09 14:50 ` [PATCH net-next 1/4] docs: ethtool: Add two link extended substates of bad signal integrity Guangbin Huang
2021-08-09 14:50 ` [PATCH net-next 2/4] ethtool: add " Guangbin Huang
2021-08-09 14:50 ` [PATCH net-next 3/4] net: hns3: add header file hns3_ethtoo.h Guangbin Huang
2021-08-09 14:50 ` [PATCH net-next 4/4] net: hns3: add support ethtool extended link state Guangbin Huang
2021-08-09 20:54 ` Jakub Kicinski
2021-08-10 1:08 ` huangguangbin (A) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15810974-d1da-2a43-7a69-45dffff653a2@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).