From: Roopa Prabhu <roopa@cumulusnetworks.com>
To: dsahern@gmail.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com,
jiri@mellanox.com, idosch@mellanox.com, petrm@mellanox.com
Subject: [PATCH net-next v4 0/5] Support for fdb ECMP nexthop groups
Date: Thu, 21 May 2020 22:26:12 -0700 [thread overview]
Message-ID: <1590125177-39176-1-git-send-email-roopa@cumulusnetworks.com> (raw)
From: Roopa Prabhu <roopa@cumulusnetworks.com>
This series introduces ecmp nexthops and nexthop groups
for mac fdb entries. In subsequent patches this is used
by the vxlan driver fdb entries. The use case is
E-VPN multihoming [1,2,3] which requires bridged vxlan traffic
to be load balanced to remote switches (vteps) belonging to
the same multi-homed ethernet segment (This is analogous to
a multi-homed LAG but over vxlan).
Changes include new nexthop flag NHA_FDB for nexthops
referenced by fdb entries. These nexthops only have ip.
The patches make sure that routes dont reference such nexthops.
example:
$ip nexthop add id 12 via 172.16.1.2 fdb
$ip nexthop add id 13 via 172.16.1.3 fdb
$ip nexthop add id 102 group 12/13 fdb
$bridge fdb add 02:02:00:00:00:13 dev vxlan1000 nhid 101 self
[1] E-VPN https://tools.ietf.org/html/rfc7432
[2] E-VPN VxLAN: https://tools.ietf.org/html/rfc8365
[3] LPC talk with mention of nexthop groups for L2 ecmp
http://vger.kernel.org/lpc_net2018_talks/scaling_bridge_fdb_database_slidesV3.pdf
v4 -
- fix error path free_skb in vxlan_xmit_nh
- fix atomic notifier initialization issue
(Reported-by: kernel test robot <rong.a.chen@intel.com>)
The reported error was easy to locate and fix, but i was not
able to re-test with the robot reproducer script due to some
other issues with running the script on my test system.
v3 - fix wording in selftest print as pointed out by davidA
v2 -
- dropped nikolays fixes for nexthop multipath null pointer deref
(he will send those separately)
- added negative tests for route add with fdb nexthop + a few more
- Fixes for a few fdb replace conditions found during more testing
- Moved to rcu_dereference_rtnl in vxlan_fdb_info and consolidate rcu
dereferences
- Fixes to build failures Reported-by: kbuild test robot <lkp@intel.com>
- DavidA, I am going to send a separate patch for the neighbor code validation
for NDA_NH_ID if thats ok.
Roopa Prabhu (5):
nexthop: support for fdb ecmp nexthops
vxlan: ecmp support for mac fdb entries
nexthop: add support for notifiers
vxlan: support for nexthop notifiers
selftests: net: add fdb nexthop tests
drivers/net/vxlan.c | 340 ++++++++++++++++++++++------
include/net/ip6_fib.h | 1 +
include/net/netns/nexthop.h | 1 +
include/net/nexthop.h | 44 ++++
include/net/vxlan.h | 25 ++
include/uapi/linux/neighbour.h | 1 +
include/uapi/linux/nexthop.h | 3 +
net/core/neighbour.c | 2 +
net/ipv4/nexthop.c | 159 +++++++++++--
net/ipv6/route.c | 5 +
tools/testing/selftests/net/fib_nexthops.sh | 160 ++++++++++++-
11 files changed, 651 insertions(+), 90 deletions(-)
--
2.1.4
next reply other threads:[~2020-05-22 5:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 5:26 Roopa Prabhu [this message]
2020-05-22 5:26 ` [PATCH net-next v4 1/5] nexthop: support for fdb ecmp nexthops Roopa Prabhu
2020-05-22 5:26 ` [PATCH net-next v4 2/5] vxlan: ecmp support for mac fdb entries Roopa Prabhu
2020-05-22 5:26 ` [PATCH net-next v4 3/5] nexthop: add support for notifiers Roopa Prabhu
2020-05-22 5:26 ` [PATCH net-next v4 4/5] vxlan: support for nexthop notifiers Roopa Prabhu
2020-05-22 5:26 ` [PATCH net-next v4 5/5] selftests: net: add fdb nexthop tests Roopa Prabhu
2020-05-22 21:01 ` [PATCH net-next v4 0/5] Support for fdb ECMP nexthop groups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590125177-39176-1-git-send-email-roopa@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=petrm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).