From: patchwork-bot+netdevbpf@kernel.org
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, ivecera@redhat.com
Subject: Re: [PATCH ethtool] netlink: fix allocation failure handling in dump_features()
Date: Thu, 15 Oct 2020 18:50:02 +0000 [thread overview]
Message-ID: <160278780283.28012.6567583320815769774.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20201014164952.CC0C860731@lion.mk-sys.cz>
Hello:
This patch was applied to ethtool/ethtool.git (refs/heads/master):
On Wed, 14 Oct 2020 18:49:52 +0200 (CEST) you wrote:
> On allocation failure, dump_features() would set ret to -ENOMEM but then
> return 0 anyway. As there is nothing to free in this case anyway, the
> easiest fix is to simply return -ENOMEM rather than jumping to out_free
> label - which can be dropped as well as this was its only use.
>
> Fixes: f2c17e107900 ("netlink: add netlink handler for gfeatures (-k)")
> Reported-by: Ivan Vecera <ivecera@redhat.com>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
>
> [...]
Here is the summary with links:
- [ethtool] netlink: fix allocation failure handling in dump_features()
https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=09c67a720a07
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2020-10-15 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 16:49 [PATCH ethtool] netlink: fix allocation failure handling in dump_features() Michal Kubecek
2020-10-15 18:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160278780283.28012.6567583320815769774.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ivecera@redhat.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).