From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B484C433DF for ; Thu, 15 Oct 2020 19:10:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7C95221EB for ; Thu, 15 Oct 2020 19:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602789006; bh=sj3HyIcKIgtG7lgmfDbWXebS3FQOZamkxyPH6dtjLHo=; h=Subject:From:Date:References:In-Reply-To:To:Cc:List-ID:From; b=ct53jhrMHD1JiqC9GMD6Oqnc751spzy2EJfpvkT9MHwoNLlw2VkFlVQpkZUIga9Ek 5slmHW9velDp2O3/pSfZZTNw/Y+qarvDX1bhUFt2h816ZDB7tXEQx9bXAu6CnTItz+ CIVJmUXAMB8WmS6eK0IPJSLZ2YD4GTY9Y2ezxYgE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728274AbgJOTKE (ORCPT ); Thu, 15 Oct 2020 15:10:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:54102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727152AbgJOTKD (ORCPT ); Thu, 15 Oct 2020 15:10:03 -0400 Content-Type: text/plain; charset="utf-8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602789003; bh=sj3HyIcKIgtG7lgmfDbWXebS3FQOZamkxyPH6dtjLHo=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=PeY7Y0CUd5BmkeSg7JGXaCyaGEqE7qMk1zG5FjmazyhCEKjM3RZOzES0rn4WgOBcQ R5MF/E1aXqYR4gYrnZoO3VRo3Uxlqky+yLx3ozCavqjNKsxdxYILhA4X/LOeVG6+AY jpAbUMRS47ZlfoohJzyXLrKJehAQbHIjA6oBABso= MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: sockmap: Don't call bpf_prog_put() on NULL pointer From: patchwork-bot+netdevbpf@kernel.org Message-Id: <160278900298.4062.17082299733897692954.git-patchwork-notify@kernel.org> Date: Thu, 15 Oct 2020 19:10:02 +0000 References: <20201012170952.60750-1-alex.dewar90@gmail.com> In-Reply-To: <20201012170952.60750-1-alex.dewar90@gmail.com> To: Alex Dewar Cc: john.fastabend@gmail.com, daniel@iogearbox.net, jakub@cloudflare.com, lmb@cloudflare.com, davem@davemloft.net, kuba@kernel.org, ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, andrii@kernel.org, kpsingh@chromium.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 12 Oct 2020 18:09:53 +0100 you wrote: > If bpf_prog_inc_not_zero() fails for skb_parser, then bpf_prog_put() is > called unconditionally on skb_verdict, even though it may be NULL. Fix > and tidy up error path. > > Addresses-Coverity-ID: 1497799: Null pointer dereferences (FORWARD_NULL) > Fixes: 743df8b7749f ("bpf, sockmap: Check skb_verdict and skb_parser programs explicitly") > Signed-off-by: Alex Dewar > > [...] Here is the summary with links: - net: sockmap: Don't call bpf_prog_put() on NULL pointer https://git.kernel.org/bpf/bpf-next/c/83c11c17553c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html