From: Loic Poulain <loic.poulain@linaro.org>
To: davem@davemloft.net, kuba@kernel.org
Cc: bjorn.andersson@linaro.org, manivannan.sadhasivam@linaro.org,
cjhuang@codeaurora.org, netdev@vger.kernel.org,
Loic Poulain <loic.poulain@linaro.org>
Subject: [PATCH v2 3/5] net: qrtr: Allow non-immediate node routing
Date: Fri, 6 Nov 2020 18:33:28 +0100 [thread overview]
Message-ID: <1604684010-24090-4-git-send-email-loic.poulain@linaro.org> (raw)
In-Reply-To: <1604684010-24090-1-git-send-email-loic.poulain@linaro.org>
In order to reach non-immediate remote node services that are
accessed through an intermediate node, the route to the remote
node needs to be saved.
E.g for a [node1 <=> node2 <=> node3] network
- node2 forwards node3 service to node1
- node1 must save node2 as route for reaching node3
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
net/qrtr/qrtr.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
index e09154b..1d12408 100644
--- a/net/qrtr/qrtr.c
+++ b/net/qrtr/qrtr.c
@@ -400,12 +400,13 @@ static void qrtr_node_assign(struct qrtr_node *node, unsigned int nid)
{
unsigned long flags;
- if (node->nid != QRTR_EP_NID_AUTO || nid == QRTR_EP_NID_AUTO)
+ if (nid == QRTR_EP_NID_AUTO)
return;
spin_lock_irqsave(&qrtr_nodes_lock, flags);
radix_tree_insert(&qrtr_nodes, nid, node);
- node->nid = nid;
+ if (node->nid == QRTR_EP_NID_AUTO)
+ node->nid = nid;
spin_unlock_irqrestore(&qrtr_nodes_lock, flags);
}
@@ -493,6 +494,13 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const void *data, size_t len)
qrtr_node_assign(node, cb->src_node);
+ if (cb->type == QRTR_TYPE_NEW_SERVER) {
+ /* Remote node endpoint can bridge other distant nodes */
+ const struct qrtr_ctrl_pkt *pkt = data + hdrlen;
+
+ qrtr_node_assign(node, le32_to_cpu(pkt->server.node));
+ }
+
if (cb->type == QRTR_TYPE_RESUME_TX) {
qrtr_tx_resume(node, skb);
} else {
--
2.7.4
next prev parent reply other threads:[~2020-11-06 17:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 17:33 [PATCH v2 0/5] net: qrtr: Add distant node support Loic Poulain
2020-11-06 17:33 ` [PATCH v2 1/5] net: qrtr: Fix port ID for control messages Loic Poulain
2020-11-06 17:33 ` [PATCH v2 2/5] net: qrtr: Allow forwarded services Loic Poulain
2020-11-06 17:33 ` Loic Poulain [this message]
2020-11-06 17:33 ` [PATCH v2 4/5] net: qrtr: Add GFP flags parameter to qrtr_alloc_ctrl_packet Loic Poulain
2020-11-06 17:33 ` [PATCH v2 5/5] net: qrtr: Release distant nodes along the bridge node Loic Poulain
2020-11-08 0:26 ` [PATCH v2 0/5] net: qrtr: Add distant node support Jakub Kicinski
2020-11-09 8:49 ` Loic Poulain
2020-11-09 18:39 ` Jakub Kicinski
2020-11-10 9:03 ` Loic Poulain
2020-11-10 17:44 ` Jakub Kicinski
2020-11-11 23:31 ` Jakub Kicinski
2020-11-12 3:14 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604684010-24090-4-git-send-email-loic.poulain@linaro.org \
--to=loic.poulain@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cjhuang@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).