* [PATCH net] net: af_packet: fix procfs header for 64-bit pointers
@ 2020-12-16 7:28 Baruch Siach
2020-12-18 20:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2020-12-16 7:28 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski; +Cc: netdev, Baruch Siach
On 64-bit systems the packet procfs header field names following 'sk'
are not aligned correctly:
sk RefCnt Type Proto Iface R Rmem User Inode
00000000605d2c64 3 3 0003 7 1 450880 0 16643
00000000080e9b80 2 2 0000 0 0 0 0 17404
00000000b23b8a00 2 2 0000 0 0 0 0 17421
...
With this change field names are correctly aligned:
sk RefCnt Type Proto Iface R Rmem User Inode
000000005c3b1d97 3 3 0003 7 1 21568 0 16178
000000007be55bb7 3 3 fbce 8 1 0 0 16250
00000000be62127d 3 3 fbcd 8 1 0 0 16254
...
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
net/packet/af_packet.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 7a18ffff8551..99de3bbe437f 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -4581,7 +4581,9 @@ static void packet_seq_stop(struct seq_file *seq, void *v)
static int packet_seq_show(struct seq_file *seq, void *v)
{
if (v == SEQ_START_TOKEN)
- seq_puts(seq, "sk RefCnt Type Proto Iface R Rmem User Inode\n");
+ seq_printf(seq,
+ "%*sRefCnt Type Proto Iface R Rmem User Inode\n",
+ IS_ENABLED(CONFIG_64BIT) ? -17 : -9, "sk");
else {
struct sock *s = sk_entry(v);
const struct packet_sock *po = pkt_sk(s);
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: af_packet: fix procfs header for 64-bit pointers
2020-12-16 7:28 [PATCH net] net: af_packet: fix procfs header for 64-bit pointers Baruch Siach
@ 2020-12-18 20:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-12-18 20:30 UTC (permalink / raw)
To: Baruch Siach; +Cc: davem, kuba, netdev
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 16 Dec 2020 09:28:04 +0200 you wrote:
> On 64-bit systems the packet procfs header field names following 'sk'
> are not aligned correctly:
>
> sk RefCnt Type Proto Iface R Rmem User Inode
> 00000000605d2c64 3 3 0003 7 1 450880 0 16643
> 00000000080e9b80 2 2 0000 0 0 0 0 17404
> 00000000b23b8a00 2 2 0000 0 0 0 0 17421
> ...
>
> [...]
Here is the summary with links:
- [net] net: af_packet: fix procfs header for 64-bit pointers
https://git.kernel.org/netdev/net/c/abdcd06c4ded
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-18 20:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 7:28 [PATCH net] net: af_packet: fix procfs header for 64-bit pointers Baruch Siach
2020-12-18 20:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).