From: patchwork-bot+netdevbpf@kernel.org
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: dsahern@gmail.com, netdev@vger.kernel.org, kuba@kernel.org,
davem@davemloft.net, bpf@vger.kernel.org, eric.dumazet@gmail.com,
borkmann@iogearbox.net, alexei.starovoitov@gmail.com
Subject: Re: [PATCH net-next V1] net: adjust net_device layout for cacheline usage
Date: Fri, 29 Jan 2021 04:50:13 +0000 [thread overview]
Message-ID: <161189581346.32508.3530556174555491097.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <161168277983.410784.12401225493601624417.stgit@firesoul>
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 26 Jan 2021 18:39:39 +0100 you wrote:
> The current layout of net_device is not optimal for cacheline usage.
>
> The member adj_list.lower linked list is split between cacheline 2 and 3.
> The ifindex is placed together with stats (struct net_device_stats),
> although most modern drivers don't update this stats member.
>
> The members netdev_ops, mtu and hard_header_len are placed on three
> different cachelines. These members are accessed for XDP redirect into
> devmap, which were noticeably with perf tool. When not using the map
> redirect variant (like TC-BPF does), then ifindex is also used, which is
> placed on a separate fourth cacheline. These members are also accessed
> during forwarding with regular network stack. The members priv_flags and
> flags are on fast-path for network stack transmit path in __dev_queue_xmit
> (currently located together with mtu cacheline).
>
> [...]
Here is the summary with links:
- [net-next,V1] net: adjust net_device layout for cacheline usage
https://git.kernel.org/netdev/net-next/c/28af22c6c8df
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2021-01-29 4:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 17:39 [PATCH net-next V1] net: adjust net_device layout for cacheline usage Jesper Dangaard Brouer
2021-01-29 3:51 ` David Ahern
2021-01-29 7:58 ` Jesper Dangaard Brouer
[not found] ` <20210129114642.139cb7dc@carbon>
2021-01-29 19:35 ` Jakub Kicinski
2021-01-29 19:47 ` Eric Dumazet
2021-01-29 20:07 ` Jakub Kicinski
2021-02-12 15:57 ` Jesper Dangaard Brouer
2021-01-29 4:50 ` patchwork-bot+netdevbpf [this message]
[not found] ` <52835f1f-96e1-b36e-2631-1182649ac3a8@gmail.com>
[not found] ` <20210129150058.34e3a855@carbon>
2021-02-12 15:49 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161189581346.32508.3530556174555491097.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).