From: patchwork-bot+netdevbpf@kernel.org
To: Jiri Olsa <jolsa@kernel.org>
Cc: ast@kernel.org, daniel@iogearbox.net, andriin@fb.com,
netdev@vger.kernel.org, bpf@vger.kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@chromium.org
Subject: Re: [PATCH] bpf: Forbid trampoline attach for functions with variable arguments
Date: Thu, 06 May 2021 23:30:09 +0000 [thread overview]
Message-ID: <162034380976.14975.13821771720470799714.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210505132529.401047-1-jolsa@kernel.org>
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Wed, 5 May 2021 15:25:29 +0200 you wrote:
> We can't currently allow to attach functions with variable arguments.
> The problem is that we should save all the registers for arguments,
> which is probably doable, but if caller uses more than 6 arguments,
> we need stack data, which will be wrong, because of the extra stack
> frame we do in bpf trampoline, so we could crash.
>
> Also currently there's malformed trampoline code generated for such
> functions at the moment as described in:
> https://lore.kernel.org/bpf/20210429212834.82621-1-jolsa@kernel.org/
>
> [...]
Here is the summary with links:
- bpf: Forbid trampoline attach for functions with variable arguments
https://git.kernel.org/bpf/bpf/c/0a1a616720d9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-05-06 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 13:25 [PATCH] bpf: Forbid trampoline attach for functions with variable arguments Jiri Olsa
2021-05-05 18:45 ` Andrii Nakryiko
2021-05-06 23:31 ` Daniel Borkmann
2021-05-07 8:13 ` Jiri Olsa
2021-05-06 23:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162034380976.14975.13821771720470799714.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).