From: patchwork-bot+netdevbpf@kernel.org
To: Esben Haabendal <esben@geanix.com>
Cc: netdev@vger.kernel.org, stable@vger.kernel.org,
davem@davemloft.net, kuba@kernel.org, michal.simek@xilinx.com,
jesse.brandeburg@intel.com, wanghai38@huawei.com, andrew@lunn.ch,
zhangchangzhong@huawei.com, michael@walle.cc,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] net: ll_temac: Make sure to free skb when it is completely used
Date: Fri, 18 Jun 2021 19:20:04 +0000 [thread overview]
Message-ID: <162404400495.12339.18313933113853867877.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <d9200a5023973fbe372a2d51dc4e500400450ecd.1624013456.git.esben@geanix.com>
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Fri, 18 Jun 2021 12:52:23 +0200 you wrote:
> With the skb pointer piggy-backed on the TX BD, we have a simple and
> efficient way to free the skb buffer when the frame has been transmitted.
> But in order to avoid freeing the skb while there are still fragments from
> the skb in use, we need to piggy-back on the TX BD of the skb, not the
> first.
>
> Without this, we are doing use-after-free on the DMA side, when the first
> BD of a multi TX BD packet is seen as completed in xmit_done, and the
> remaining BDs are still being processed.
>
> [...]
Here is the summary with links:
- [1/4] net: ll_temac: Make sure to free skb when it is completely used
https://git.kernel.org/netdev/net/c/6aa32217a9a4
- [2/4] net: ll_temac: Add memory-barriers for TX BD access
https://git.kernel.org/netdev/net/c/28d9fab458b1
- [3/4] net: ll_temac: Fix TX BD buffer overwrite
https://git.kernel.org/netdev/net/c/c364df2489b8
- [4/4] net: ll_temac: Avoid ndo_start_xmit returning NETDEV_TX_BUSY
https://git.kernel.org/netdev/net/c/f63963411942
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-06-18 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 10:52 [PATCH 1/4] net: ll_temac: Make sure to free skb when it is completely used Esben Haabendal
2021-06-18 10:52 ` [PATCH 2/4] net: ll_temac: Add memory-barriers for TX BD access Esben Haabendal
2021-06-18 10:52 ` [PATCH 3/4] net: ll_temac: Fix TX BD buffer overwrite Esben Haabendal
2021-06-18 10:52 ` [PATCH 4/4] net: ll_temac: Avoid ndo_start_xmit returning NETDEV_TX_BUSY Esben Haabendal
2021-06-18 19:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162404400495.12339.18313933113853867877.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=esben@geanix.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wanghai38@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).