From: patchwork-bot+netdevbpf@kernel.org
To: Jakub Sitnicki <jakub@cloudflare.com>
Cc: john.fastabend@gmail.com, daniel@iogearbox.net,
lmb@cloudflare.com, ast@kernel.org, andrii@kernel.org,
xiyou.wangcong@gmail.com, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf v2] bpf, sockmap, udp: sk_prot needs inuse_idx set for proc stats
Date: Thu, 15 Jul 2021 18:00:05 +0000 [thread overview]
Message-ID: <162637200551.28238.8602014526032832150.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210714154750.528206-1-jakub@cloudflare.com>
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Wed, 14 Jul 2021 17:47:50 +0200 you wrote:
> Proc socket stats use sk_prot->inuse_idx value to record inuse sock stats.
> We currently do not set this correctly from sockmap side. The result is
> reading sock stats '/proc/net/sockstat' gives incorrect values. The
> socket counter is incremented correctly, but because we don't set the
> counter correctly when we replace sk_prot we may omit the decrement.
>
> To get the correct inuse_idx value move the core_initcall that initializes
> the udp proto handlers to late_initcall. This way it is initialized after
> UDP has the chance to assign the inuse_idx value from the register protocol
> handler.
>
> [...]
Here is the summary with links:
- [bpf,v2] bpf, sockmap, udp: sk_prot needs inuse_idx set for proc stats
https://git.kernel.org/bpf/bpf/c/54ea2f49fd94
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-07-15 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 15:47 [PATCH bpf v2] bpf, sockmap, udp: sk_prot needs inuse_idx set for proc stats Jakub Sitnicki
2021-07-15 3:48 ` Cong Wang
2021-07-15 18:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162637200551.28238.8602014526032832150.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).