* [net] net/sched: fix incorrect vlan_push_eth dest field
@ 2022-03-23 9:25 louis.peens
2022-03-23 17:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: louis.peens @ 2022-03-23 9:25 UTC (permalink / raw)
To: davem, kuba; +Cc: maord, roid, netdev, oss-drivers, Louis Peens
From: Louis Peens <louis.peens@corigine.com>
Seems like a potential copy-paste bug slipped in here,
the second memcpy should of course be populating src
and not dest.
Fixes: ab95465cde23 ("net/sched: add vlan push_eth and pop_eth action to the hardware IR")
Signed-off-by: Louis Peens <louis.peens@corigine.com>
---
include/net/tc_act/tc_vlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/tc_act/tc_vlan.h b/include/net/tc_act/tc_vlan.h
index a97600f742de..904eddfc1826 100644
--- a/include/net/tc_act/tc_vlan.h
+++ b/include/net/tc_act/tc_vlan.h
@@ -84,7 +84,7 @@ static inline void tcf_vlan_push_eth(unsigned char *src, unsigned char *dest,
{
rcu_read_lock();
memcpy(dest, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_dst, ETH_ALEN);
- memcpy(dest, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_src, ETH_ALEN);
+ memcpy(src, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_src, ETH_ALEN);
rcu_read_unlock();
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net] net/sched: fix incorrect vlan_push_eth dest field
2022-03-23 9:25 [net] net/sched: fix incorrect vlan_push_eth dest field louis.peens
@ 2022-03-23 17:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-23 17:50 UTC (permalink / raw)
To: Louis Peens; +Cc: davem, kuba, maord, roid, netdev, oss-drivers
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 23 Mar 2022 11:25:06 +0200 you wrote:
> From: Louis Peens <louis.peens@corigine.com>
>
> Seems like a potential copy-paste bug slipped in here,
> the second memcpy should of course be populating src
> and not dest.
>
> Fixes: ab95465cde23 ("net/sched: add vlan push_eth and pop_eth action to the hardware IR")
> Signed-off-by: Louis Peens <louis.peens@corigine.com>
>
> [...]
Here is the summary with links:
- [net] net/sched: fix incorrect vlan_push_eth dest field
https://git.kernel.org/netdev/net-next/c/054d5575cd6e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-23 17:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-23 9:25 [net] net/sched: fix incorrect vlan_push_eth dest field louis.peens
2022-03-23 17:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).