From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F19C2BCA1 for ; Fri, 7 Jun 2019 18:56:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD87420868 for ; Fri, 7 Jun 2019 18:56:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="JKBmHUup" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732350AbfFGS4v (ORCPT ); Fri, 7 Jun 2019 14:56:51 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:41076 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730290AbfFGS4t (ORCPT ); Fri, 7 Jun 2019 14:56:49 -0400 Received: by mail-ed1-f65.google.com with SMTP id p15so4393720eds.8 for ; Fri, 07 Jun 2019 11:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:date:message-id:in-reply-to:references:user-agent :subject:mime-version:content-transfer-encoding; bh=pLHqHIiNEMpqBsq1VQWJdA+f/ogiGuALrvYvfOsre5w=; b=JKBmHUupUT1En6Wm/PaAfDvWLs9G4reHIL/Dq7a28RXjQhW1bvj1OuB26Otd3Nzv/F 5ZMid02V6ON7krE7muBA6YEhkfXI5N+61Qho5iv95IBFh/MlqvIhkuqMpLLIh4Gx1vis dD6p2HlT0owEbyLmy2rgkQ9McTJKn+DOb7v3g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:date:message-id:in-reply-to :references:user-agent:subject:mime-version :content-transfer-encoding; bh=pLHqHIiNEMpqBsq1VQWJdA+f/ogiGuALrvYvfOsre5w=; b=Bugtqo1SaNvabYDJXnbLwUp+5cU35udKAQOY9XdWT84/i3IVF3J66yJYpCrY1uMvtH UM1DSeEWAXeI69dRVPM/7Gd4i0dV1pMSZ4BiGUO38jeHdQ2LwSKT2E1h2fGZyqccgkj7 KOVUYxkReR3PnxP+DzH6esFzjHQcfuQlFa9i/wZCFYysfM5oR+HQwKC/juH6UTBQH8nf WkRwiHj97A5pZuzx6g4Yu+1pdeK3xZVrQT3LB9I45PJ+h5ap1Pcyz0iWrO4JxQPe4iOc CDiiZCPDParLGezEXiaDMQSe4r9nXLWTXJB8vXxYl1w7rB53GXdOnfg1VSmeCAtUj0f8 fLww== X-Gm-Message-State: APjAAAXh2dvCqi9OSAKIKadLwT1aPLJfMyy/6C3x8d4cnwrRU7LyKsUn BaJIWVDkw/8aotborTpyVudZuA== X-Google-Smtp-Source: APXvYqy/QInNnOY8qOmxzPqvg5vvvunnvhTKvbvtqEaMLJvI0LfXEgZqTasv/6lBtFt2xGxRunVBpA== X-Received: by 2002:a17:906:4ada:: with SMTP id u26mr28479238ejt.258.1559933807813; Fri, 07 Jun 2019 11:56:47 -0700 (PDT) Received: from [192.168.178.17] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id f9sm501183ejt.18.2019.06.07.11.56.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 07 Jun 2019 11:56:47 -0700 (PDT) From: Arend Van Spriel To: Doug Anderson CC: Adrian Hunter , Ulf Hansson , Kalle Valo , , "open list:ARM/Rockchip SoC..." , Double Lo , Brian Norris , "linux-wireless" , Naveen Gupta , Madhan Mohan R , Matthias Kaehlcke , Wright Feng , "Chi-Hsien Lin" , netdev , "brcm80211-dev-list" , "David S. Miller" , Franky Lin , LKML , Hante Meuleman , YueHaibing , Michael Trimarchi Date: Fri, 07 Jun 2019 20:56:43 +0200 Message-ID: <16b334cd9f8.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: References: <20190603183740.239031-1-dianders@chromium.org> <20190603183740.239031-4-dianders@chromium.org> <42fc30b1-adab-7fa8-104c-cbb7855f2032@intel.com> <16b305a7110.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <16b3223dea0.2764.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> User-Agent: AquaMail/1.20.0-1451 (build: 102000001) Subject: Re: [PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On June 7, 2019 8:06:30 PM Doug Anderson wrote: > Hi, > > On Fri, Jun 7, 2019 at 6:32 AM Arend Van Spriel > wrote: >> >> Right. I know it supports initial tuning, but I'm not sure about subsequent >> retuning initiated by the host controller. > > My evidence says that it supports subsequent tuning. In fact, without > this series my logs would be filled with: > > dwmmc_rockchip ff0d0000.dwmmc: Successfully tuned phase to XYZ > > ...where the phase varied by a few degrees each time. AKA: it was > retuning over and over again and getting sane results which implies > that the tuning was working just fine. Ok. Thanks for confirming this. Regards, Arend