From: David Ahern <dsahern@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Madhu Challa <challa@noironetworks.com>,
"David S . Miller" <davem@davemloft.net>,
Jianlin Shi <jishi@redhat.com>
Subject: Re: [PATCHv2 net] ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set
Date: Fri, 23 Aug 2019 08:41:16 -0400 [thread overview]
Message-ID: <174e57e3-664c-e355-91f5-eea4997b6de9@gmail.com> (raw)
In-Reply-To: <20190822082012.GE18865@dhcp-12-139.nay.redhat.com>
On 8/22/19 4:20 AM, Hangbin Liu wrote:
> On Mon, Aug 19, 2019 at 10:33:58PM -0400, David Ahern wrote:
>> On 8/19/19 10:19 PM, Hangbin Liu wrote:
>>> But in ipv6_add_addr() it will check the address type and reject multicast
>>> address directly. So this feature is never worked for IPv6.
>>
>> If true, that is really disappointing.
>>
>> We need to get a functional test script started for various address cases.
>
> Do you mean an `ip addr add` testing for all kinds of address types?
>
yes.
next prev parent reply other threads:[~2019-08-23 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 13:52 [PATCH net] ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set Hangbin Liu
2019-08-20 0:32 ` David Miller
2019-08-20 2:19 ` [PATCHv2 " Hangbin Liu
2019-08-20 2:33 ` David Ahern
2019-08-22 8:20 ` Hangbin Liu
2019-08-23 12:41 ` David Ahern [this message]
2019-08-22 3:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174e57e3-664c-e355-91f5-eea4997b6de9@gmail.com \
--to=dsahern@gmail.com \
--cc=challa@noironetworks.com \
--cc=davem@davemloft.net \
--cc=jishi@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).