From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
erkin.bozoglu@xeront.com, netdev <netdev@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:MIPS" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 05/10] mips: dts: ralink: mt7621: fix some dtc warnings
Date: Thu, 15 Sep 2022 10:25:44 +0300 [thread overview]
Message-ID: <17638FC4-A129-4620-9BD3-E47AA653A113@arinc9.com> (raw)
In-Reply-To: <CAMhs-H87WFJJgFEkZ7XeBsBMJKfZdzUjVChqb3_KbRqPodwTrg@mail.gmail.com>
> On 15 Sep 2022, at 10:17, Sergio Paracuellos <sergio.paracuellos@gmail.com> wrote:
>
> Hi Arinc,
>
>> On Thu, Sep 15, 2022 at 8:56 AM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>>
>> Fix the dtc warnings below.
>>
>> uartlite@c00: $nodename:0: 'uartlite@c00' does not match '^serial(@.*)?$'
>> From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/serial/8250.yaml
>> uartlite@c00: Unevaluated properties are not allowed ('clock-names' was unexpected)
>> From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/serial/8250.yaml
>> sdhci@1e130000: $nodename:0: 'sdhci@1e130000' does not match '^mmc(@.*)?$'
>> From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>> sdhci@1e130000: Unevaluated properties are not allowed ('bus-width', 'cap-mmc-highspeed', 'cap-sd-highspeed', 'disable-wp', 'max-frequency', 'vmmc-supply', 'vqmmc-supply' were unexpected)
>> From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>> xhci@1e1c0000: $nodename:0: 'xhci@1e1c0000' does not match '^usb(@.*)?'
>> From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
>> xhci@1e1c0000: compatible: ['mediatek,mt8173-xhci'] is too short
>> From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
>> switch0@0: $nodename:0: 'switch0@0' does not match '^(ethernet-)?switch(@.*)?$'
>> From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
>> port@1: status:0: 'off' is not one of ['okay', 'disabled', 'reserved']
>> From schema: /home/arinc9/.local/lib/python3.10/site-packages/dtschema/schemas/dt-core.yaml
>> port@2: status:0: 'off' is not one of ['okay', 'disabled', 'reserved']
>> From schema: /home/arinc9/.local/lib/python3.10/site-packages/dtschema/schemas/dt-core.yaml
>> port@3: status:0: 'off' is not one of ['okay', 'disabled', 'reserved']
>> From schema: /home/arinc9/.local/lib/python3.10/site-packages/dtschema/schemas/dt-core.yaml
>>
>> - Change "uartlite: uartlite@c00" to "serial0: serial@c00" and remove the
>> aliases node.
>> - Remove "clock-names" from the serial0 node. The property doesn't exist on
>> the 8250.yaml schema.
>> - Change "sdhci: sdhci@1e130000" to "mmc: mmc@1e130000".
>> - Change "xhci: xhci@1e1c0000" to "usb: usb@1e1c0000".
>> - Add "mediatek,mtk-xhci" as the second compatible string on the usb node.
>> - Change "switch0: switch0@0" to "switch0: switch@0"
>> - Change "off" to "disabled" for disabled nodes.
>>
>> Remaining warnings are caused by the lack of json-schema documentation.
>
> The followings needs to be ported to yaml schema but exist in its
> previous txt format:
>
>>
>> /cpuintc: failed to match any schema with compatible: ['mti,cpu-interrupt-controller']
>
> https://elixir.bootlin.com/linux/v6.0-rc5/source/Documentation/devicetree/bindings/mips/cpu_irq.txt#L13
>
>> /palmbus@1e000000/wdt@100: failed to match any schema with compatible: ['mediatek,mt7621-wdt']
>
> https://elixir.bootlin.com/linux/v6.0-rc5/source/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt#L4
>
>> /palmbus@1e000000/i2c@900: failed to match any schema with compatible: ['mediatek,mt7621-i2c']
>
> https://elixir.bootlin.com/linux/v6.0-rc5/source/Documentation/devicetree/bindings/i2c/i2c-mt7621.txt#L6
>
>> /palmbus@1e000000/spi@b00: failed to match any schema with compatible: ['ralink,mt7621-spi']
>
> https://elixir.bootlin.com/linux/v6.0-rc5/source/Documentation/devicetree/bindings/spi/spi-mt7621.txt#L5
>
>> /ethernet@1e100000: failed to match any schema with compatible: ['mediatek,mt7621-eth']
>
> https://elixir.bootlin.com/linux/v6.0-rc5/source/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt#L15
This binding is old and does not represent the current mtk_eth_soc driver. I already remove this with the first patch in the series so I’d rather do a new schema from scratch.
Arınç
next prev parent reply other threads:[~2022-09-15 7:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 6:55 [PATCH v2 net-next 00/10] dt-bindings and mt7621 devicetree changes Arınç ÜNAL
2022-09-15 6:55 ` [PATCH v2 net-next 01/10] dt-bindings: net: drop old mediatek bindings Arınç ÜNAL
2022-09-15 6:55 ` [PATCH v2 net-next 02/10] dt-bindings: net: dsa: mediatek,mt7530: change mt7530 switch address Arınç ÜNAL
2022-09-15 6:55 ` [PATCH v2 net-next 03/10] dt-bindings: net: dsa: mediatek,mt7530: expand gpio-controller description Arınç ÜNAL
2022-09-15 6:55 ` [PATCH v2 net-next 04/10] dt-bindings: memory: mt7621: add syscon as compatible string Arınç ÜNAL
2022-09-16 19:41 ` Rob Herring
2022-09-16 21:48 ` Arınç ÜNAL
2022-09-15 6:55 ` [PATCH v2 net-next 05/10] mips: dts: ralink: mt7621: fix some dtc warnings Arınç ÜNAL
2022-09-15 7:17 ` Sergio Paracuellos
2022-09-15 7:25 ` Arınç ÜNAL [this message]
2022-09-15 6:55 ` [PATCH v2 net-next 06/10] mips: dts: ralink: mt7621: remove interrupt-parent from switch node Arınç ÜNAL
2022-09-15 6:55 ` [PATCH v2 net-next 07/10] mips: dts: ralink: mt7621: change phy-mode of gmac1 to rgmii Arınç ÜNAL
2022-09-15 6:55 ` [PATCH v2 net-next 08/10] mips: dts: ralink: mt7621: change mt7530 switch address Arınç ÜNAL
2022-09-15 6:55 ` [PATCH v2 net-next 09/10] mips: dts: ralink: mt7621: fix external phy on GB-PC2 Arınç ÜNAL
2022-09-15 6:55 ` [PATCH v2 net-next 10/10] mips: dts: ralink: mt7621: add GB-PC2 LEDs Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17638FC4-A129-4620-9BD3-E47AA653A113@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).