From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE80C43381 for ; Tue, 19 Feb 2019 19:38:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EB1C20855 for ; Tue, 19 Feb 2019 19:38:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pNoAfGC2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727147AbfBSTiD (ORCPT ); Tue, 19 Feb 2019 14:38:03 -0500 Received: from mail-yw1-f68.google.com ([209.85.161.68]:44858 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbfBSTiD (ORCPT ); Tue, 19 Feb 2019 14:38:03 -0500 Received: by mail-yw1-f68.google.com with SMTP id x21so8221565ywx.11 for ; Tue, 19 Feb 2019 11:38:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/pNJE1Q/WJXP1/OwuIhCxxMaVzKBLkUUzNWNgl2LxT0=; b=pNoAfGC2sr2YNegwh0jgpTp1xGINIY45ekH+bSOJi+RzcJ+xV/ZZ7wzHrzCiNfNlwl tu3OWcJkziOuBP3mOl4fWeIWZrUiXXqeCxN1KS/AI9xvDmKFq53AgAtrBFUMLRtgTafe tB1GoSFGdNuOElDPq30m2F8yBHC7Y2c+l7atV+Nei3ndARw4BAR+9eP+3R20+7aQYJ49 AlqeX6CBfLxnibM0HHaxNxYaUqOmw/EtjLjHaQo7jRN/7wBxk6t1OOufUVnhAO8McVDM cRvClJnzr3UGNdwTMBbTr/RXU9htDjzbDNAZmZ6ON91tFOURhoLCjY6aW74icllq63o5 9r0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/pNJE1Q/WJXP1/OwuIhCxxMaVzKBLkUUzNWNgl2LxT0=; b=l0fdtmeSL6mII7W0AOH8xhtw5KOk0IGrAEDSvgM5vCxPfyzt8VVw8gvpk+mjwQnS3o K7gsKO0ZZiiCtmpnMgNPkwKIcYrUB3PMuDYobF2oyZ32j/+ZoM8Wg6ytbJcLI9p3m8QB sOw8rDPDUxbsQBT7Csm7n+YuIxFHS9ANPLGh1GHSiLOS9hBRMBxzzBFkvQtOUqP6UnUQ cPHatv1VdoGXq2tvjpjUM/IAnh+eICDpWS70jpqzj38RTbodwI0IV2dDZ2MNgfVqj/yd 774WMdPvhZPRs176xnazAY83gQN0pVsoYCbRWTGo/HqEJh5shOxPFd+CBSbhSYQ2V+M+ 6U8g== X-Gm-Message-State: AHQUAuamdPl4K0LJlW7mOu2J6cgr7A6oDzz2uCqvC1Ax6oPoSIP1vjHO UsvZhnqx2ozy5iFkdASUObkuJxcJ X-Google-Smtp-Source: AHgI3IbGqdiD6V16lybbEj1528gHEiLnZ3H4WJcpNvvugcbntJFbGZ9wAbeiJkg1J+KlTaw8sTSFYQ== X-Received: by 2002:a0d:eb8a:: with SMTP id u132mr24766311ywe.36.1550605081271; Tue, 19 Feb 2019 11:38:01 -0800 (PST) Received: from [10.67.49.152] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id g193sm7241682ywh.57.2019.02.19.11.37.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 11:38:00 -0800 (PST) Subject: Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: add support for bridge flags To: Russell King - ARM Linux admin , Vivien Didelot Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org References: <20190217163114.yomawlljyxlqy3ob@shell.armlinux.org.uk> <20190219111612.GF27578@t480s.localdomain> <20190219162435.f5zl5harbarwy6bj@shell.armlinux.org.uk> <20190219120000.GB4140@t480s.localdomain> <20190219171414.cvaiw7u2xnd5zk3g@shell.armlinux.org.uk> <20190219123828.GD10959@t480s.localdomain> <20190219180811.qxsu2ss3g7jwhgfb@shell.armlinux.org.uk> <20190219140444.GD16594@t480s.localdomain> <20190219191016.u65vvw5y3iydt5zx@shell.armlinux.org.uk> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <17ed5462-eef5-4b1d-6d32-a8a8d03d6c87@gmail.com> Date: Tue, 19 Feb 2019 11:37:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190219191016.u65vvw5y3iydt5zx@shell.armlinux.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/19/19 11:10 AM, Russell King - ARM Linux admin wrote: > On Tue, Feb 19, 2019 at 02:04:44PM -0500, Vivien Didelot wrote: >> Hi Russell, >> >> On Tue, 19 Feb 2019 18:08:11 +0000, Russell King - ARM Linux admin wrote: >>> Having these as separate functions means that we would then need >>> additional complexity in mv88e6xxx to store the per-port flooding state, >>> so we can do this: >>> >>> reg &= ~MV88E6352_PORT_CTL0_EGRESS_FLOODS_MASK; >>> >>> if (unicast && multicast) >>> reg |= MV88E6352_PORT_CTL0_EGRESS_FLOODS_ALL_UNKNOWN_DA; >>> else if (unicast) >>> reg |= MV88E6352_PORT_CTL0_EGRESS_FLOODS_NO_UNKNOWN_MC_DA; >>> else if (multicast) >>> reg |= MV88E6352_PORT_CTL0_EGRESS_FLOODS_NO_UNKNOWN_UC_DA; >>> else >>> reg |= MV88E6352_PORT_CTL0_EGRESS_FLOODS_NO_UNKNOWN_DA; >>> >>> for some of the switches. It looks to me like mv88e6xxx would prefer >>> having at least both the unicast and multicast flags together. >>> >>> Even without that, it means more code in mv88e6xxx to wrap each of >>> these calls between the DSA ops and the chip specific ops... >> >> True, let's stick with ops->port_egress_flood(ds, port, bool uc, bool mc). >> I do not think that it is necessary to add support for BR_BCAST_FLOOD yet, >> we can extend this routine later if we need to. >> >> Your dsa_port_bridge_flags() core function can notify the understood >> features. This will allow us to scope the support of the bridge flags in >> the core, and preventing the drivers to do that themselves. > > So, if we have ops->port_egress_flood, then we tell bridge that > we support BR_FLOOD | BR_MCAST_FLOOD, irrespective of whether the > bridge actually supports both? I have a patch series which removes the need for BRIDGE_FLAGS_SUPPORT and requires you to implement an attribute setter for PRE_BRIDGE_FLAGS, there, you can map that to the same DSA switch operations and check the flags and deny one or both that the driver does not support. Should I re-send it and you submit on top, or the other way around? Either way is fine, just tell me. -- Florian