From: Saeed Mahameed <saeed@kernel.org>
To: Alex Elder <elder@linaro.org>, davem@davemloft.net, kuba@kernel.org
Cc: evgreen@chromium.org, bjorn.andersson@linaro.org,
cpratapa@codeaurora.org, subashab@codeaurora.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/6] net: ipa: GSI interrupt updates
Date: Thu, 14 Jan 2021 15:22:54 -0800 [thread overview]
Message-ID: <183ca04bc2b03a5f9c64fa29a3148983e4594963.camel@kernel.org> (raw)
In-Reply-To: <20210113171532.19248-1-elder@linaro.org>
On Wed, 2021-01-13 at 11:15 -0600, Alex Elder wrote:
> This series implements some updates for the GSI interrupt code,
> buliding on some bug fixes implemented last month.
>
> The first two are simple changes made to improve readability and
> consistency. The third replaces all msleep() calls with comparable
> usleep_range() calls.
>
> The remainder make some more substantive changes to make the code
> align with recommendations from Qualcomm. The fourth implements a
> much shorter timeout for completion GSI commands, and the fifth
> implements a longer delay between retries of the STOP channel
> command. Finally, the last implements retries for stopping TX
> channels (in addition to RX channels).
>
> -Alex
>
A minor thing that bothers me about this series is that it looks like
it is based on magic numbers and some redefined constant values
according to some mysterious sources ;-) .. It would be nice to have
some wording in the commit messages explaining reasoning and maybe
"semi-official" sources behind the changes.
LGMT code style wise :)
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
> Alex Elder (6):
> net: ipa: a few simple renames
> net: ipa: introduce some interrupt helpers
> net: ipa: use usleep_range()
> net: ipa: change GSI command timeout
> net: ipa: change stop channel retry delay
> net: ipa: retry TX channel stop commands
>
> drivers/net/ipa/gsi.c | 140 +++++++++++++++++++----------
> ----
> drivers/net/ipa/ipa_endpoint.c | 4 +-
> 2 files changed, 83 insertions(+), 61 deletions(-)
>
next prev parent reply other threads:[~2021-01-14 23:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 17:15 [PATCH net-next 0/6] net: ipa: GSI interrupt updates Alex Elder
2021-01-13 17:15 ` [PATCH net-next 1/6] net: ipa: a few simple renames Alex Elder
2021-01-13 17:15 ` [PATCH net-next 2/6] net: ipa: introduce some interrupt helpers Alex Elder
2021-01-13 17:15 ` [PATCH net-next 3/6] net: ipa: use usleep_range() Alex Elder
2021-01-13 17:15 ` [PATCH net-next 4/6] net: ipa: change GSI command timeout Alex Elder
2021-01-13 17:15 ` [PATCH net-next 5/6] net: ipa: change stop channel retry delay Alex Elder
2021-01-13 17:15 ` [PATCH net-next 6/6] net: ipa: retry TX channel stop commands Alex Elder
2021-01-14 23:22 ` Saeed Mahameed [this message]
2021-01-15 2:08 ` [PATCH net-next 0/6] net: ipa: GSI interrupt updates Jakub Kicinski
2021-01-15 10:42 ` Alex Elder
2021-01-15 18:59 ` Jakub Kicinski
2021-01-15 19:06 ` Alex Elder
2021-01-15 10:36 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=183ca04bc2b03a5f9c64fa29a3148983e4594963.camel@kernel.org \
--to=saeed@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).