From: Heiner Kallweit <hkallweit1@gmail.com>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>, netdev@vger.kernel.org
Cc: andrew@lunn.ch, f.fainelli@gmail.com, kernel@pengutronix.de
Subject: Re: [PATCH v2] net: phy: dp83867: Set FORCE_LINK_GOOD to default after reset
Date: Tue, 14 Jan 2020 20:21:20 +0100 [thread overview]
Message-ID: <1871867b-717d-ba43-4a6e-1b469867b0aa@gmail.com> (raw)
In-Reply-To: <20200114164553.12997-1-m.grzeschik@pengutronix.de>
On 14.01.2020 17:45, Michael Grzeschik wrote:
> According to the Datasheet this bit should be 0 (Normal operation) in
> default. With the FORCE_LINK_GOOD bit set, it is not possible to get a
> link. This patch sets FORCE_LINK_GOOD to the default value after
> resetting the phy.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> v1 -> v2: - fixed typo in subject line
> - used phy_modify instead of read/write
>
> drivers/net/phy/dp83867.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
> index adda0d0eab800..68855177d92cc 100644
> --- a/drivers/net/phy/dp83867.c
> +++ b/drivers/net/phy/dp83867.c
> @@ -99,6 +99,7 @@
> #define DP83867_PHYCR_TX_FIFO_DEPTH_MASK GENMASK(15, 14)
> #define DP83867_PHYCR_RX_FIFO_DEPTH_MASK GENMASK(13, 12)
> #define DP83867_PHYCR_RESERVED_MASK BIT(11)
> +#define DP83867_PHYCR_FORCE_LINK_GOOD BIT(10)
>
> /* RGMIIDCTL bits */
> #define DP83867_RGMII_TX_CLK_DELAY_MAX 0xf
> @@ -635,6 +636,15 @@ static int dp83867_phy_reset(struct phy_device *phydev)
>
> usleep_range(10, 20);
>
> + /* After reset FORCE_LINK_GOOD bit is set. Although the
> + * default value should be unset. Disable FORCE_LINK_GOOD
> + * for the phy to work properly.
> + */
> + err = phy_modify(phydev, MII_DP83867_PHYCTRL,
> + DP83867_PHYCR_FORCE_LINK_GOOD, 0);
> + if (err < 0)
> + return err;
> +
> return 0;
You can simply do "return phy_modify();" here.
> }
>
>
next prev parent reply other threads:[~2020-01-14 19:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 11:24 [PATCH] net: phy: dp83867: Set FORCE_LINK_GOOD do default after reset Michael Grzeschik
2020-01-14 13:25 ` Andrew Lunn
2020-01-14 16:45 ` [PATCH v2] net: phy: dp83867: Set FORCE_LINK_GOOD to " Michael Grzeschik
2020-01-14 19:21 ` Heiner Kallweit [this message]
2020-01-15 8:01 ` [PATCH v3] " Michael Grzeschik
2020-01-16 12:57 ` David Miller
2020-01-16 13:16 ` [PATCH v4] " Michael Grzeschik
2020-01-16 23:48 ` Andrew Lunn
2020-01-17 10:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1871867b-717d-ba43-4a6e-1b469867b0aa@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).