From: Jiabing Wan <wanjiabing@vivo.com>
To: Antoine Tenart <atenart@kernel.org>, Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] net: phy: mscc: Add error check when __phy_read() failed
Date: Wed, 11 May 2022 11:23:04 +0800 [thread overview]
Message-ID: <18a40fc4-75a7-2619-71e4-80b50b133abb@vivo.com> (raw)
In-Reply-To: <165219683693.3924.12337336334738761045@kwain>
On 2022/5/10 23:33, Antoine Tenart wrote:
> Quoting Andrew Lunn (2022-05-10 17:08:07)
>> But i doubt this impacts real users. MDIO tends to either work or not
>> work at all. And not working is pretty noticeable, and nobody has
>> reported issues.
> Right. On top of that there are other calls to __phy_read in this driver
> not checking the returned value. Plus all __phy_write calls. If that was
> found by code inspection I would suggest to improve the whole driver and
> not this function alone.
OK, I'll try to improve the whole driver and send a patch set for this.
Thanks,
Wan Jiabing
next prev parent reply other threads:[~2022-05-11 3:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 14:22 [PATCH v2 net] net: phy: mscc: Add error check when __phy_read() failed Wan Jiabing
2022-05-10 14:48 ` Antoine Tenart
2022-05-10 15:08 ` Andrew Lunn
2022-05-10 15:33 ` Antoine Tenart
2022-05-11 3:23 ` Jiabing Wan [this message]
2022-05-11 10:45 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18a40fc4-75a7-2619-71e4-80b50b133abb@vivo.com \
--to=wanjiabing@vivo.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).