netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Wu <lekensteyn@gmail.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] realtek: convert to per-chip mask
Date: Tue, 23 Jul 2013 23:03:45 +0200	[thread overview]
Message-ID: <1969296.8vWT4XT66S@al> (raw)
In-Reply-To: <20130723202437.GC31567@electric-eye.fr.zoreil.com>

On Tuesday 23 July 2013 22:24:37 Francois Romieu wrote:
> Peter Wu <lekensteyn@gmail.com> :
> [...]
> > +	[RTL8100E1] = "RTL-8100E(1)",
> > +	[RTL8100E2] = "RTL-8100E(2)",
> 
> Tab after equal may be.
Originally I had [NAME <tab(s)>] = ..., but then checkpatch complained. I will 
fix it up.

> The "RTL-" prefix string could be shared.
Good point, I will also fix.

Regards,
Peter

  reply	other threads:[~2013-07-23 21:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  8:51 [ethtool] Add new Realtek devices Peter Wu
2013-07-23  8:51 ` [PATCH 1/2] realtek: convert to per-chip mask Peter Wu
2013-07-23 17:56   ` Ben Hutchings
2013-07-23  8:51 ` [PATCH 2/2] realtek: update devices to 3.11 Peter Wu
2013-07-23 18:04 ` [PATCH v2 " Peter Wu
2013-07-23 18:05 ` [PATCH v2 1/2] realtek: convert to per-chip mask Peter Wu
2013-07-23 20:24   ` Francois Romieu
2013-07-23 21:03     ` Peter Wu [this message]
2013-07-23 20:25 ` [ethtool] Add new Realtek devices Francois Romieu
2013-07-23 21:08   ` Peter Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1969296.8vWT4XT66S@al \
    --to=lekensteyn@gmail.com \
    --cc=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --subject='Re: [PATCH v2 1/2] realtek: convert to per-chip mask' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).