From: David Laight <David.Laight@ACULAB.COM>
To: 'Heiner Kallweit' <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
"Realtek linux nic maintainers" <nic_swsd@realtek.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net] r8169: disable hw csum for short packets and chip versions with hw padding bug
Date: Thu, 5 Nov 2020 14:20:56 +0000 [thread overview]
Message-ID: <1a20cb5755db4916b873d88460ccf19e@AcuMS.aculab.com> (raw)
In-Reply-To: <e82f7f4d-8d45-1e7c-a2ef-5a8bfc3992c6@gmail.com>
From: Heiner Kallweit
> Sent: 05 November 2020 13:58
>
> RTL8125B has same or similar short packet hw padding bug as RTL8168evl.
> The main workaround has been extended accordingly, however we have to
> disable also hw checksumming for short packets on affected new chip
> versions. Change the code in a way that in case of further affected
> chip versions we have to add them in one place only.
Why not just disable hw checksumming for short packets on
all devices (that use this driver).
It can't make much difference to the performance.
The lack of conditionals may even make it faster.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-11-05 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 13:58 [PATCH net] r8169: disable hw csum for short packets and chip versions with hw padding bug Heiner Kallweit
2020-11-05 14:20 ` David Laight [this message]
2020-11-05 14:35 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a20cb5755db4916b873d88460ccf19e@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).