From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tom Herbert <tom@herbertland.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: Flow label persistence
Date: Thu, 19 Nov 2020 18:56:44 +0100 [thread overview]
Message-ID: <1a40fa35-6ef0-5b42-3505-b23763309165@gmail.com> (raw)
In-Reply-To: <CALx6S353fPF=x4=yr4=a4zYCKVLfCRbFhEKr14A1mBRug7AfaA@mail.gmail.com>
On 11/19/20 4:49 PM, Tom Herbert wrote:
> HI,
>
> A potential issue came up on v6ops list in IETF that Linux stack
> changes the flow label for a connection at every RTO, this is the
> feature where we change the txhash on a failing connection to try to
> find a route (the flow label is derived from the txhash). The problem
> with changing the flow label for a connection is that it may cause
> problems when stateful middleboxes are in the path, for instance if a
> flow label change causes packets for a connection to take a different
> route they might be forwarded to a different stateful firewall that
> didn't see the 3WHS so don't have any flow state and hence drop the
> packets.
>
> I was under the assumption that we had a sysctl that would enable
> changing the txhash for a connection and the default was off so that
> flow labels would be persistent for the life of the connection.
> Looking at the code now, I don't see that safety net, it looks like
> the defauly behavior allows changing the hash. Am I missing something?
>
> Thanks,
> Tom
>
"Stateful middleboxes" using flowlabels to identify a flow instead of the
standard 4-tuple are broken.
No sysctl addition/change can possibly help, since it wont appear magically
on billions of linux hosts.
Your question is a bit ironic, since historically you wrote the
first change for this stuff, without a sysctl.
commit 265f94ff54d62503663d9c788ba1f082e448f8b8
Author: Tom Herbert <tom@herbertland.com>
Date: Tue Jul 28 16:02:06 2015 -0700
net: Recompute sk_txhash on negative routing advice
When a connection is failing a transport protocol calls
dst_negative_advice to try to get a better route. This patch includes
changing the sk_txhash in that function. This provides a rudimentary
method to try to find a different path in the network since sk_txhash
affects ECMP on the local host and through the network (via flow labels
or UDP source port in encapsulation).
Signed-off-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2020-11-19 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 15:49 Flow label persistence Tom Herbert
2020-11-19 17:56 ` Eric Dumazet [this message]
2020-11-19 19:18 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a40fa35-6ef0-5b42-3505-b23763309165@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).