From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
davem@davemloft.net, sunilmut@microsoft.com, willemb@google.com,
sgarzare@redhat.com, stefanha@redhat.com, ytht.net@gmail.com,
arnd@arndb.de, tglx@linutronix.de, decui@microsoft.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] vsock: Simplify '__vsock_release()'
Date: Thu, 31 Oct 2019 10:48:53 +0100 [thread overview]
Message-ID: <1b33ca33-a02b-1923-cbee-814e520b9700@wanadoo.fr> (raw)
In-Reply-To: <c7a0b6b0-96cd-1fd3-3d98-94a3692bda38@cogentembedded.com>
Le 31/10/2019 à 10:36, Sergei Shtylyov a écrit :
> Hello!
>
> On 31.10.2019 9:47, Christophe JAILLET wrote:
>
>> Use '__skb_queue_purge()' instead of re-implementing it.
>
> In don't see that double underscore below...
This is a typo in the commit message.
There is no need for __ because skb_dequeue was used.
Could you fix it directly in the commit message (preferred solution for
me) or should I send a V2?
CJ
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> net/vmw_vsock/af_vsock.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
>> index 2ab43b2bba31..2983dc92ca63 100644
>> --- a/net/vmw_vsock/af_vsock.c
>> +++ b/net/vmw_vsock/af_vsock.c
> [...]
>> @@ -662,8 +661,7 @@ static void __vsock_release(struct sock *sk, int
>> level)
>> sock_orphan(sk);
>> sk->sk_shutdown = SHUTDOWN_MASK;
>> - while ((skb = skb_dequeue(&sk->sk_receive_queue)))
>> - kfree_skb(skb);
>> + skb_queue_purge(&sk->sk_receive_queue);
>> /* Clean up any sockets that never were accepted. */
>> while ((pending = vsock_dequeue_accept(sk)) != NULL) {
>
> MBR, Sergei
>
next prev parent reply other threads:[~2019-10-31 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 6:47 [PATCH] vsock: Simplify '__vsock_release()' Christophe JAILLET
2019-10-31 9:07 ` Stefano Garzarella
2019-10-31 9:36 ` Sergei Shtylyov
2019-10-31 9:48 ` Christophe JAILLET [this message]
2019-11-02 17:11 ` Stefano Garzarella
2019-11-01 8:08 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b33ca33-a02b-1923-cbee-814e520b9700@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=sunilmut@microsoft.com \
--cc=tglx@linutronix.de \
--cc=willemb@google.com \
--cc=ytht.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).