From: "zhangsha (A)" <zhangsha.zhang@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: "j.vosburgh@gmail.com" <j.vosburgh@gmail.com>,
"vfalico@gmail.com" <vfalico@gmail.com>,
"andy@greyhouse.net" <andy@greyhouse.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
yuehaibing <yuehaibing@huawei.com>,
hunongda <hunongda@huawei.com>,
"Chenzhendong (alex)" <alex.chen@huawei.com>
Subject: RE: [PATCH v2] bonding: force enable lacp port after link state recovery for 802.3ad
Date: Thu, 29 Aug 2019 11:33:10 +0000 [thread overview]
Message-ID: <1bca4169ed95402eb32448379f56c2aa@huawei.com> (raw)
In-Reply-To: <20190827.150456.509211205582645335.davem@davemloft.net>
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: 2019年8月28日 6:05
> To: zhangsha (A) <zhangsha.zhang@huawei.com>
> Cc: j.vosburgh@gmail.com; vfalico@gmail.com; andy@greyhouse.net;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; yuehaibing
> <yuehaibing@huawei.com>; hunongda <hunongda@huawei.com>;
> Chenzhendong (alex) <alex.chen@huawei.com>
> Subject: Re: [PATCH v2] bonding: force enable lacp port after link state
> recovery for 802.3ad
>
> From: <zhangsha.zhang@huawei.com>
> Date: Fri, 23 Aug 2019 11:42:09 +0800
>
> > - If speed/duplex getting failed here, the link status
> > will be changed to BOND_LINK_FAIL;
>
> How does it fail at this step? I suspect this is a driver specific problem.
Hi, David,
I'm really sorry for the delayed email and appreciated for your feedback.
I was testing in kernel 4.19 with a Huawei hinic card when the problem occurred.
I checked the dmesg and got the logs in the following order:
1) link status definitely down for interface eth6, disabling it
2) link status up again after 0 ms for interface eth6
3) the paterner's system mac becomes to "00:00:00:00:00:00".
By reading the codes, I think that the link status of the slave should be changed
to BOND_LINK_FAIL from BOND_LINK_DOWN.
As this problem has only occurred once only, I am not very sure about whether this is a
driver specific problem or not at the moment. But I find the commit 4d2c0cda,
its log says " Some NIC drivers don't have correct speed/duplex settings at the
time they send NETDEV_UP notification ...", so I prefer to believe it's not.
To my problem I think it is not enough that link-monitoring (miimon) only set
SPEED/DUPLEX right, the lacp port should be enabled too at the same time.
next prev parent reply other threads:[~2019-08-29 11:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 3:42 [PATCH v2] bonding: force enable lacp port after link state recovery for 802.3ad zhangsha.zhang
2019-08-27 22:04 ` David Miller
2019-08-29 11:33 ` zhangsha (A) [this message]
2019-08-28 20:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bca4169ed95402eb32448379f56c2aa@huawei.com \
--to=zhangsha.zhang@huawei.com \
--cc=alex.chen@huawei.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=hunongda@huawei.com \
--cc=j.vosburgh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).