archive mirror
 help / color / mirror / Atom feed
From: "Arınç ÜNAL" <>
To: Andrew Lunn <>
Cc: "DENG Qingfang" <>,
	"Luiz Angelo Daros de Luca" <>,
	"Matthias Brugger" <>,
	"John Crispin" <>,
	"Siddhant Gupta" <>,
	"Ilya Lipnitskiy" <>,
	"Sergio Paracuellos" <>,
	"Felix Fietkau" <>,
	"Sean Wang" <>,
	"Mark Lee" <>,
	"Russell King" <>,
	"Jakub Kicinski" <>,
	"David Miller" <>,
	"René van Dorst" <>,
	"moderated list:ARM/Mediatek SoC support"
	netdev <>,,
Subject: Re: MT7621 SoC Traffic Won't Flow on RGMII2 Bus/2nd GMAC
Date: Sun, 23 Jan 2022 20:48:21 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 23/01/2022 18:26, Andrew Lunn wrote:
> On Sun, Jan 23, 2022 at 11:33:04AM +0300, Arınç ÜNAL wrote:
>> Hey Deng,
>> On 23/01/2022 09:51, DENG Qingfang wrote:
>>> Hi,
>>> Do you set the ethernet pinmux correctly?
>>> &ethernet {
>>>       pinctrl-names = "default";
>>>       pinctrl-0 = <&rgmii1_pins &rgmii2_pins &mdio_pins>;
>>> };
>> This fixed it! We did have &rgmii2_pins on the gmac1 node (it was originally
>> on external_phy) so we never thought to investigate the pinctrl
>> configuration further! Turns out &rgmii2_pins needs to be defined on the
>> ethernet node instead.
> PHYs are generally external, so pinmux on them makes no sense. PHYs in
> DT are not devices in the usual sense, so i don't think the driver
> core will handle pinmux for them, even if you did list them.
> This could be interesting for the DT compliance checker. Ideally we
> want it to warn if it finds a pinmux configuration in a PHY node.

I don't see any warnings about it:

$ cpp -nostdinc -I include -I arch -undef -x assembler-with-cpp 
drivers/staging/mt7621-dts/mt7621.dtsi mt7621.dtsi.preprocessed
$ dtc -I dts -O dtb -p 0x1000 mt7621.dtsi.preprocessed -o mt7621.dtb
drivers/staging/mt7621-dts/mt7621.dtsi:28.21-33.4: Warning 
(unit_address_vs_reg): /cpuintc@0: node has a unit name, but no reg property
drivers/staging/mt7621-dts/mt7621.dtsi:40.34-47.6: Warning 
(unit_address_vs_reg): /fixedregulator@0: node has a unit name, but no 
reg property
drivers/staging/mt7621-dts/mt7621.dtsi:49.39-56.4: Warning 
(unit_address_vs_reg): /fixedregulator@1: node has a unit name, but no 
reg property
drivers/staging/mt7621-dts/mt7621.dtsi:410.11-449.7: Warning 
(unit_address_vs_reg): /ethernet@1e100000/mdio-bus/switch0@0/ports: node 
has a reg or ranges property, but no unit name
drivers/staging/mt7621-dts/mt7621.dtsi:28.21-33.4: Warning 
(unique_unit_address): /cpuintc@0: duplicate unit-address (also used in 
node /fixedregulator@0)

> It also sounds like you had them somewhere else wrong?

Yes, it was under the phy_external node:

I had put it under gmac1 node instead since we didn't enable the 
phy_external node.


  reply	other threads:[~2022-01-23 17:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-22 18:01 MT7621 SoC Traffic Won't Flow on RGMII2 Bus/2nd GMAC Arınç ÜNAL
2022-01-23  6:51 ` DENG Qingfang
2022-01-23  8:33   ` Arınç ÜNAL
2022-01-23 15:26     ` Andrew Lunn
2022-01-23 17:48       ` Arınç ÜNAL [this message]
2022-01-24 17:13       ` Florian Fainelli
2022-01-24 17:26         ` Russell King (Oracle)
2022-01-24 17:34           ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).