From: Jacob Keller <jacob.e.keller@intel.com>
To: Yunsheng Lin <linyunsheng@huawei.com>, netdev@vger.kernel.org
Cc: valex@mellanox.com, jiri@resnulli.us
Subject: Re: [PATCH v2 0/3] devlink region trigger support
Date: Fri, 10 Jan 2020 09:52:18 -0800 [thread overview]
Message-ID: <1d00deb9-16fc-b2a5-f8f7-5bb8316dbac2@intel.com> (raw)
In-Reply-To: <4d8fe881-8d36-06dd-667a-276a717a0d89@huawei.com>
On 1/9/2020 8:10 PM, Yunsheng Lin wrote:
> On 2020/1/10 3:33, Jacob Keller wrote:
>> This series consists of patches to enable devlink to request a snapshot via
>> a new DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT.
>>
>> A reviewer might notice that the devlink health API already has such support
>> for handling a similar case. However, the health API does not make sense in
>> cases where the data is not related to an error condition.
>
> Maybe we need to specify the usecases for the region trigger as suggested by
> Jacob.
>
> For example, the orginal usecase is to expose some set of flash/NVM contents.
> But can it be used to dump the register of the bar space? or some binary
> table in the hardware to debug some error that is not detected by hw?
>
regions can essentially be used to dump arbitrary addressable content. I
think all of the above are great examples.
I have a series of patches to update and convert the devlink
documentation, and I do provide some further detail in the new
devlink-region.rst file.
Perhaps you could review that and provide suggestions on what would make
sense to add there?
https://lore.kernel.org/netdev/20200109224625.1470433-13-jacob.e.keller@intel.com/
Thanks,
Jake
next prev parent reply other threads:[~2020-01-10 17:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 19:33 [PATCH v2 0/3] devlink region trigger support Jacob Keller
2020-01-09 19:33 ` [PATCH v2 1/3] devlink: add callback to trigger region snapshots Jacob Keller
2020-01-09 19:33 ` [PATCH v2 1/1] devlink: add support for DEVLINK_CMD_REGION_TRIGGER Jacob Keller
2020-01-09 19:33 ` [PATCH v2 2/3] devlink: introduce command to trigger region snapshot Jacob Keller
2020-01-09 19:33 ` [PATCH v2 3/3] netdevsim: support triggering snapshot through devlink Jacob Keller
2020-01-09 20:13 ` [PATCH v2 0/3] devlink region trigger support Jacob Keller
2020-01-10 4:10 ` Yunsheng Lin
2020-01-10 17:52 ` Jacob Keller [this message]
2020-01-11 1:51 ` Yunsheng Lin
2020-01-12 20:45 ` Jakub Kicinski
2020-01-12 21:18 ` Alex Vesker
2020-01-13 1:39 ` Yunsheng Lin
2020-01-13 11:34 ` Jakub Kicinski
2020-01-13 18:16 ` Jacob Keller
2020-01-13 18:33 ` Jiri Pirko
2020-01-13 16:58 ` Jiri Pirko
2020-01-13 18:22 ` Jacob Keller
2020-01-13 18:33 ` Jiri Pirko
2020-01-14 8:33 ` Yunsheng Lin
2020-01-14 20:04 ` Jacob Keller
2020-01-15 8:36 ` Yunsheng Lin
2020-01-10 9:40 ` Jiri Pirko
2020-01-10 17:54 ` Jacob Keller
2020-01-10 18:47 ` Jakub Kicinski
2020-01-10 18:57 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d00deb9-16fc-b2a5-f8f7-5bb8316dbac2@intel.com \
--to=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).