netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org
Cc: Sudheesh.Mavila@amd.com
Subject: Re: [PATCH 0/4] Bug fixes to amd-xgbe driver
Date: Fri, 12 Feb 2021 10:57:30 -0800	[thread overview]
Message-ID: <1e573155-9900-7bdf-9b8d-442359a291fc@gmail.com> (raw)
In-Reply-To: <20210212180010.221129-1-Shyam-sundar.S-k@amd.com>



On 2/12/2021 10:00 AM, Shyam Sundar S K wrote:
> General fixes on amd-xgbe driver are addressed in this series, mostly
> on the mailbox communication failures and improving the link stability
> of the amd-xgbe device.
> 
> Shyam Sundar S K (4):
>   amd-xgbe: Reset the PHY rx data path when mailbox command timeout
>   amd-xgbe: Fix NETDEV WATCHDOG transmit queue timeout warning
>   amd-xgbe: Reset link when the link never comes back
>   amd-xgbe: Fix network fluctuations when using 1G BELFUSE SFP

If these are all bugfixes there would be an expectation that you provide
appropriate Fixes: tag in your commit messages to designate which commit
introduced the problem, you may also want to make it clear in the patch
subject that this is intended for the "net" tree which collects bug
fixes, see:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n28

> 
>  drivers/net/ethernet/amd/xgbe/xgbe-common.h | 13 +++++++
>  drivers/net/ethernet/amd/xgbe/xgbe-drv.c    |  1 +
>  drivers/net/ethernet/amd/xgbe/xgbe-mdio.c   |  3 +-
>  drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 39 ++++++++++++++++++++-
>  4 files changed, 53 insertions(+), 3 deletions(-)
> 

-- 
Florian

      parent reply	other threads:[~2021-02-12 18:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 18:00 [PATCH 0/4] Bug fixes to amd-xgbe driver Shyam Sundar S K
2021-02-12 18:00 ` [PATCH 1/4] amd-xgbe: Reset the PHY rx data path when mailbox command timeout Shyam Sundar S K
2021-02-12 18:43   ` Tom Lendacky
2021-02-12 18:00 ` [PATCH 2/4] amd-xgbe: Fix NETDEV WATCHDOG transmit queue timeout warning Shyam Sundar S K
2021-02-12 18:48   ` Tom Lendacky
2021-02-12 18:00 ` [PATCH 3/4] amd-xgbe: Reset link when the link never comes back Shyam Sundar S K
2021-02-12 19:01   ` Tom Lendacky
2021-02-12 18:00 ` [PATCH 4/4] amd-xgbe: Fix network fluctuations when using 1G BELFUSE SFP Shyam Sundar S K
2021-02-12 18:56   ` Florian Fainelli
2021-02-12 19:05   ` Tom Lendacky
2021-02-12 21:14   ` Heiner Kallweit
2021-02-12 18:57 ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e573155-9900-7bdf-9b8d-442359a291fc@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=Sudheesh.Mavila@amd.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).