From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52451C3A5A6 for ; Wed, 28 Aug 2019 09:14:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 290FC217F5 for ; Wed, 28 Aug 2019 09:14:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="PIAg8Lbv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbfH1JOo (ORCPT ); Wed, 28 Aug 2019 05:14:44 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:39352 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726504AbfH1JOo (ORCPT ); Wed, 28 Aug 2019 05:14:44 -0400 Received: by mail-lf1-f66.google.com with SMTP id l11so1513972lfk.6 for ; Wed, 28 Aug 2019 02:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W/FAvQVJWH8hNDqsZxVjsvHGWQ4cwiHioyZRXaiwuH4=; b=PIAg8LbvLk6D0489+QlpDRqaNqGp/RCZ4+jhKkMhIiBc2/Dd3RlrzlBuLBC/HxydEC QowWxlIXSFCcvN/jGvd5Yg34idYzc6aCxnbN9klxRc2JGYBnbpeUz9ypAbTiLWzJQDRT iBK3ZNZNyvZkdpdEu8eEdu99LWq66flJeWzenx7xEGLkUp88abcmEZKA6dk+/iar2gLY H1vbyG5EMg0ssZr0n/1cAP/1YrdQoleL/mzP+YJhRVJIZOX1DwxNN4fN/b7cb7tU4B8r JOis9BEPUMSlTEBN92wV0/IvRHOioQfaupKTQCtVIOfksaLch4G9E2qhx7HKkD9eQG+S G+Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W/FAvQVJWH8hNDqsZxVjsvHGWQ4cwiHioyZRXaiwuH4=; b=SbY0BMin6arfRfWA478DL735zZXJbQFuBG6U7THktnSVV8Fzknjcs6PGJwds4uECdm vj/PCSQI6B92snoCloxJXk5FXIHH/Qbg1UXxhbS61g3Rw/TK0amOhfCNqg1wzmRue1S4 nmifsFN4MH03+jeg35Hus9mkGs6rMNbIRTtqEN48esvUeAWg+c3hhhyi7ZAEK4gt66Vy LKPvRP57MxOKzVKkIWNO/yRFRg29fzxMKf3JRu7eJqGvYaI4dRCutIMd89IxzUozRwPc Dw4hVExHhWgH7H3SqYVIWHEr8/XtxTjhmxJDal5/UAk6uiYm6R7F9r7pJ5gVGr5GVlCO o82A== X-Gm-Message-State: APjAAAXL2AhaU2SIkcXDQWj1mXu/9qStmaQ/ag58LhiHziPnPyDBPxuk NqnMsjjxeA2p8eYX5HVxS/VPZg== X-Google-Smtp-Source: APXvYqyxt6ENbz8kd9XK40+sRsJvEZ4lHaMldtpiGWZ4JbUMbRrBUe5f2u6ARgH7OgzyukMvezH8qQ== X-Received: by 2002:ac2:43ad:: with SMTP id t13mr2097116lfl.66.1566983681773; Wed, 28 Aug 2019 02:14:41 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:43c:79c5:cc63:c37e:a616:212b? ([2a00:1fa0:43c:79c5:cc63:c37e:a616:212b]) by smtp.gmail.com with ESMTPSA id h15sm498484ljl.64.2019.08.28.02.14.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Aug 2019 02:14:41 -0700 (PDT) Subject: Re: [PATCH] arcnet: capmode: remove redundant assignment to pointer pkt To: Colin King , Michael Grzeschik , "David S . Miller" , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190827112954.26677-1-colin.king@canonical.com> From: Sergei Shtylyov Message-ID: <1e784ee7-c049-1155-ab7e-a90f1f20f3dd@cogentembedded.com> Date: Wed, 28 Aug 2019 12:14:31 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190827112954.26677-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello! On 27.08.2019 14:29, Colin King wrote: > From: Colin Ian King > > Pointer pkt is being initialized with a value that is never read > and pkg is being re-assigned a little later on. The assignment is ^^^ pkt > redundant and hence can be removed. > > Addresses-Coverity: ("Ununsed value") > Signed-off-by: Colin Ian King [...] MBR, Sergei