From: Hakan Jansson <hakan.jansson@infineon.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode
Date: Thu, 5 May 2022 15:11:09 +0200 [thread overview]
Message-ID: <1e8cfbc6-8452-0e87-9713-536d235e5b51@infineon.com> (raw)
In-Reply-To: <CACRpkdY3xPcyNcJfdGbSP5rdcUV6hr87yJNDVDGZdRCfN+MqLA@mail.gmail.com>
Hi Linus,
Thanks for responding.
On 5/5/2022 12:15 AM, Linus Walleij wrote:
> On Wed, May 4, 2022 at 11:04 AM Hakan Jansson
> <hakan.jansson@infineon.com> wrote:
>
>> + brcm,uses-autobaud-mode:
>> + type: boolean
>> + description: >
>> + The controller should be started in autobaud mode by asserting
>> + BT_UART_CTS_N (i.e. host RTS) during startup. Only HCI commands supported
>> + in autobaud mode should be used until patch FW has been loaded.
> Things like gnss uses the current-speed attribute to set a serial link speed,
> maybe also Bluetooth?
As far as I can tell, not many Bluetooth drivers use the current-speed
attribute yet but perhaps it would be a good idea to start using it more
broadly in the future to set the initial serial link speed.
>
> Would it make sense to use
>
> current-speed-auto;
>
> As a flag for these things in general?
I suppose a general flag could be useful but to be honest I don't know
if any other devices besides the ones using the Broadcom driver has any
use for it. You would probably also still want to be able to use
current-speed to set the link speed and end up using both
current-speed=x and current-speed-auto at the same time, which might
look a little confusing?
Please let me know if you'd still prefer "current-speed-auto" over
"brcm,uses-autobaud-mode" and I'll revise the patch and rename it!
>
> Yours,
> Linus Walleij
Thanks,
Håkan
next prev parent reply other threads:[~2022-05-05 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 9:03 [PATCH 0/2] Bluetooth: hci_bcm: Autobaud mode support Hakan Jansson
2022-05-04 9:03 ` [PATCH 1/2] dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode Hakan Jansson
2022-05-04 22:15 ` Linus Walleij
2022-05-05 13:11 ` Hakan Jansson [this message]
2022-05-05 14:13 ` Linus Walleij
2022-05-05 16:16 ` Hakan Jansson
2022-05-19 14:04 ` Hakan Jansson
2022-05-19 20:49 ` Linus Walleij
2022-05-04 9:03 ` [PATCH 2/2] Bluetooth: hci_bcm: Add support for FW loading in " Hakan Jansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e8cfbc6-8452-0e87-9713-536d235e5b51@infineon.com \
--to=hakan.jansson@infineon.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).