From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Seung-Woo Kim <sw0312.kim@samsung.com>,
franky.lin@broadcom.com, hante.meuleman@broadcom.com,
chi-hsien.lin@cypress.com, wright.feng@cypress.com,
kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com
Cc: smoch@web.de, sandals@crustytoothpaste.net, rafal@milecki.pl,
digetx@gmail.com, double.lo@cypress.com, amsr@cypress.com,
stanley.hsu@cypress.com, saravanan.shanmugham@cypress.com,
jean-philippe@linaro.org, frank.kao@cypress.com,
netdev@vger.kernel.org, jh80.chung@samsung.com
Subject: Re: [PATCH] brcmfmac: Fix memory leak for unpaired brcmf_{alloc/free}
Date: Tue, 27 Oct 2020 14:19:41 +0100 [thread overview]
Message-ID: <1f7b3975-69cb-ef04-ec52-269f375c65c1@broadcom.com> (raw)
In-Reply-To: <1603795630-14638-1-git-send-email-sw0312.kim@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
On 10/27/2020 11:47 AM, Seung-Woo Kim wrote:
> There are missig brcmf_free() for brcmf_alloc(). Fix memory leak
> by adding missed brcmf_free().
Probably should add Fixes: tag for commit a1f5aac1765af. See this link
[1] about the proper format.
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Reported-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> .../wireless/broadcom/brcm80211/brcmfmac/pcie.c | 6 ++++--
> .../wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 +
> 2 files changed, 5 insertions(+), 2 deletions(-)
[1]
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#fixes_line_is_incorrect
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4176 bytes --]
prev parent reply other threads:[~2020-10-27 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201027104456epcas1p44c0f3c748f5aa52da1725d3e5a24b3de@epcas1p4.samsung.com>
2020-10-27 10:47 ` [PATCH] brcmfmac: Fix memory leak for unpaired brcmf_{alloc/free} Seung-Woo Kim
2020-10-27 13:19 ` Arend Van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f7b3975-69cb-ef04-ec52-269f375c65c1@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=amsr@cypress.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=davem@davemloft.net \
--cc=digetx@gmail.com \
--cc=double.lo@cypress.com \
--cc=frank.kao@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=jean-philippe@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=sandals@crustytoothpaste.net \
--cc=saravanan.shanmugham@cypress.com \
--cc=smoch@web.de \
--cc=stanley.hsu@cypress.com \
--cc=sw0312.kim@samsung.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).