netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Daniel Lezcano <daniel.lezcano@free.fr>
Cc: davem@davemloft.net, opurdila@ixiacom.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net-2.6 : fix dev_get_valid_name
Date: Tue, 18 May 2010 10:54:51 -0700	[thread overview]
Message-ID: <20100518105451.05b060e8@nehalam> (raw)
In-Reply-To: <1274204112-8920-1-git-send-email-daniel.lezcano@free.fr>

On Tue, 18 May 2010 19:35:12 +0200
Daniel Lezcano <daniel.lezcano@free.fr> wrote:

> +static int dev_get_valid_name(struct net_device *dev, const char *name, bool fmt)
>  {
> +	struct net *net;
> +
> +	BUG_ON(!dev_net(dev));
> +	net = dev_net(dev);

This is not really part of the same fix. And not sure why it is added here?

-- 

  reply	other threads:[~2010-05-18 17:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-18 17:35 [PATCH] net-2.6 : fix dev_get_valid_name Daniel Lezcano
2010-05-18 17:54 ` Stephen Hemminger [this message]
2010-05-18 19:55   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100518105451.05b060e8@nehalam \
    --to=shemminger@vyatta.com \
    --cc=daniel.lezcano@free.fr \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=opurdila@ixiacom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).