Netdev Archive on lore.kernel.org
 help / color / Atom feed
From: Jiri Pirko <jpirko@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: mingo@elte.hu, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH, REVERT] Re: [forcedeth bug] Re: [GIT] Networking
Date: Fri, 5 Aug 2011 12:26:01 +0200
Message-ID: <20110805102600.GC1928@minipsycho.orion> (raw)
In-Reply-To: <20110805.031953.239005825626336696.davem@davemloft.net>

Fri, Aug 05, 2011 at 12:19:53PM CEST, davem@davemloft.net wrote:
>From: Ingo Molnar <mingo@elte.hu>
>Date: Fri, 5 Aug 2011 12:16:25 +0200
>
>> I have reverted the two forcedeth commits:
>> 
>>   0891b0e08937: forcedeth: fix vlans
>>   3326c784c9f4: forcedeth: do vlan cleanup
>> 
>> and also reverted two vlan commits that the pre-cleanup driver 
>> depended on:
>> 
>>   ffcf9b767293: vlan: kill vlan_gro_frags and vlan_gro_receive
>>   7890a5b9cbfd: vlan: kill ndo_vlan_rx_register
>> 
>> and this finally gave me a working forcedeth driver. I've attached 
>> the working revert below.
>
>Jiri please diagnose this immediately otherwise I will have to apply
>Ingo's reverts.
>
>Ingo has been reporting this regression for days and you haven't said
>anything.  That's not acceptable.

Sorry, but first time I saw this was ~3hours ago. Looking at it
(reserving systems, compiling with ingo's config, etc) since then...

/me cannot be faster.


  reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22 14:33 David Miller
2011-08-01 15:13 ` Ingo Molnar
2011-08-04 21:53   ` [forcedeth bug] " Ingo Molnar
2011-08-05 10:16     ` [PATCH, REVERT] " Ingo Molnar
2011-08-05 10:19       ` David Miller
2011-08-05 10:26         ` Jiri Pirko [this message]
2011-08-05 10:22     ` Jiri Pirko
2011-08-05 10:29       ` Ingo Molnar
2011-08-05 11:12         ` Neil Horman
2011-08-05 11:44           ` Jiri Pirko
2011-08-05 11:25         ` Jiri Pirko
2011-08-05 12:18           ` Ingo Molnar
2011-08-05 12:31             ` Jiri Pirko
2011-08-05 14:37               ` Jiri Pirko
2011-08-09 13:13                 ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110805102600.GC1928@minipsycho.orion \
    --to=jpirko@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git