From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Holt Subject: Re: [PATCH v11 5/5] powerpc: Fix up fsl-flexcan device tree binding. Date: Wed, 10 Aug 2011 12:19:33 -0500 Message-ID: <20110810171933.GW4926@sgi.com> References: <1312993670-23999-1-git-send-email-holt@sgi.com> <1312993670-23999-6-git-send-email-holt@sgi.com> <4E42B83C.2040705@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, U Bhaskar-B22300 , Kumar Gala , Grant Likely , Marc Kleine-Budde , PPC list , Wolfgang Grandegger To: Scott Wood Return-path: Content-Disposition: inline In-Reply-To: <4E42B83C.2040705-KZfg59tc24xl57MIdRCFDg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Wed, Aug 10, 2011 at 11:56:28AM -0500, Scott Wood wrote: > On 08/10/2011 11:27 AM, Robin Holt wrote: > > -CPI Clock- Can Protocol Interface Clock > > - This CLK_SRC bit of CTRL(control register) selects the clock source to > > - the CAN Protocol Interface(CPI) to be either the peripheral clock > > - (driven by the PLL) or the crystal oscillator clock. The selected clock > > - is the one fed to the prescaler to generate the Serial Clock (Sclock). > > - The PRESDIV field of CTRL(control register) controls a prescaler that > > - generates the Serial Clock (Sclock), whose period defines the > > - time quantum used to compose the CAN waveform. > > +- compatible : Should be "fsl,flexcan" and optionally > > + "fsl,flexcan-" > > fsl,-flexcan, and it should not be optional, and should come > before "fsl,flexcan". > > Also may want to list fsl,p1010-rdb as a "canonical compatible" for > anything which is backwards compatible with p1010's implementation. How do I specify 'canonical compatible'? What would be the use of it in that implementation? Robin