From: David Miller <davem@davemloft.net>
To: kuninori.morimoto.gx@gmail.com
Cc: kuninori.morimoto.gx@renesas.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3 v2] net/irda: sh_sir: add missing header
Date: Thu, 11 Aug 2011 05:53:57 -0700 (PDT) [thread overview]
Message-ID: <20110811.055357.1702109063499880852.davem@davemloft.net> (raw)
In-Reply-To: <874o1owb82.wl%kuninori.morimoto.gx@renesas.com>
From: kuninori.morimoto.gx@gmail.com
Date: Thu, 11 Aug 2011 02:26:09 -0700 (PDT)
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> This patch fixup below build error on sh_sir
>
> sh_sir.c: In function 'sh_sir_write':
> sh_sir.c:127:2: error: implicit declaration of function 'iowrite16'
> sh_sir.c: In function 'sh_sir_read':
> sh_sir.c:132:2: error: implicit declaration of function 'ioread16'
> sh_sir.c: At top level:
> sh_sir.c:561:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sh_sir_irq'
> sh_sir.c: In function 'sh_sir_probe':
> sh_sir.c:727:2: error: implicit declaration of function 'ioremap_nocache'
> sh_sir.c:727:16: warning: assignment makes pointer from integer without a cast
> sh_sir.c:762:2: error: implicit declaration of function 'request_irq'
> sh_sir.c:762:23: error: 'sh_sir_irq' undeclared (first use in this function)
> sh_sir.c:762:23: note: each undeclared identifier is reported only once for each function it appears in
> sh_sir.c:762:35: error: 'IRQF_DISABLED' undeclared (first use in this function)
> sh_sir.c:776:2: error: implicit declaration of function 'iounmap'
> sh_sir.c: At top level:
> sh_sir.c:436:13: warning: 'sh_sir_clear_all_err' defined but not used
> sh_sir.c:474:12: warning: 'sh_sir_is_which_phase' defined but not used
> sh_sir.c:490:13: warning: 'sh_sir_tx' defined but not used
> sh_sir.c:540:13: warning: 'sh_sir_rx' defined but not used
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Applied.
next prev parent reply other threads:[~2011-08-11 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87aabgwl9y.wl%kuninori.morimoto.gx@renesas.com>
2011-08-11 6:15 ` [PATCH] net: sh_irda: fixup build error on v3.1 David Miller
2011-08-11 9:02 ` Kuninori Morimoto
2011-08-11 9:19 ` [PATCH v2] " Kuninori Morimoto
2011-08-11 9:25 ` [PATCH 1/3 v2] net/irda: sh_irda: add missing header kuninori.morimoto.gx
2011-08-11 12:53 ` David Miller
2011-08-11 9:26 ` [PATCH 2/3 v2] net/irda: sh_sir: " kuninori.morimoto.gx
2011-08-11 12:53 ` David Miller [this message]
2011-08-11 9:26 ` [PATCH 3/3] net/irda: sh_sir: tidyup compile warning kuninori.morimoto.gx
2011-08-11 12:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811.055357.1702109063499880852.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).